Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29987564: Noissue - Fixed: background_color option was ignored in builds for MS Edge (Closed)

Created:
Jan. 22, 2019, 8:05 p.m. by Sebastian Noack
Modified:
Jan. 25, 2019, 8:23 p.m.
Reviewers:
tlucas
Visibility:
Public.

Description

Noissue - Fixed: background_color option was ignored in builds for MS Edge

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M packagerEdge.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/expecteddata/AppxManifest_edge_development_build.xml View 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/AppxManifest_edge_release_build.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Sebastian Noack
Jan. 22, 2019, 8:06 p.m. (2019-01-22 20:06:30 UTC) #1
Sebastian Noack
I went ahead landing this change in order to not block the upcoming release. But ...
Jan. 25, 2019, 12:25 a.m. (2019-01-25 00:25:16 UTC) #2
tlucas
Jan. 25, 2019, 1:10 p.m. (2019-01-25 13:10:34 UTC) #3
On 2019/01/25 00:25:16, Sebastian Noack wrote:
> I went ahead landing this change in order to not block the upcoming release.
But
> feel free to still review the change, if you like.

LGTM - FWIW

Powered by Google App Engine
This is Rietveld