Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: packagerEdge.py

Issue 29987564: Noissue - Fixed: background_color option was ignored in builds for MS Edge (Closed)
Patch Set: Created Jan. 22, 2019, 8:05 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tests/expecteddata/AppxManifest_edge_development_build.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This Source Code Form is subject to the terms of the Mozilla Public 1 # This Source Code Form is subject to the terms of the Mozilla Public
2 # License, v. 2.0. If a copy of the MPL was not distributed with this 2 # License, v. 2.0. If a copy of the MPL was not distributed with this
3 # file, You can obtain one at http://mozilla.org/MPL/2.0/. 3 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
4 4
5 import os 5 import os
6 import shutil 6 import shutil
7 import json 7 import json
8 import re 8 import re
9 from StringIO import StringIO 9 from StringIO import StringIO
10 from glob import glob 10 from glob import glob
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 ]), 81 ]),
82 ('_d:Properties/_d:PublisherDisplayName', author, []), 82 ('_d:Properties/_d:PublisherDisplayName', author, []),
83 ('_d:Properties/_d:Logo', assets[50], []), 83 ('_d:Properties/_d:Logo', assets[50], []),
84 ('_d:Dependencies/_d:TargetDeviceFamily', None, [ 84 ('_d:Dependencies/_d:TargetDeviceFamily', None, [
85 ('MaxVersionTested', v_max), 85 ('MaxVersionTested', v_max),
86 ('MinVersion', v_min), 86 ('MinVersion', v_min),
87 ]), 87 ]),
88 ('_d:Applications/_d:Application/uap:VisualElements', None, [ 88 ('_d:Applications/_d:Application/uap:VisualElements', None, [
89 ('Square150x150Logo', assets[150]), 89 ('Square150x150Logo', assets[150]),
90 ('Square44x44Logo', assets[44]), 90 ('Square44x44Logo', assets[44]),
91 ('BackgroundColor', metadata.get('general', 'background_color')),
91 ]), 92 ]),
92 ] 93 ]
93 94
94 try: 95 try:
95 overrides.append(( 96 overrides.append((
96 '_d:Applications/_d:Application/_d:Extensions/' + 97 '_d:Applications/_d:Application/_d:Extensions/' +
97 'uap3:Extension/uap3:AppExtension', 98 'uap3:Extension/uap3:AppExtension',
98 None, 99 None,
99 [('Id', packager.get_build_specific_option(release_build, 100 [('Id', packager.get_build_specific_option(release_build,
100 metadata, 101 metadata,
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
231 cmd = ['npm', 'run', '--silent', 'package-edge'] 232 cmd = ['npm', 'run', '--silent', 'package-edge']
232 233
233 subprocess.check_call(cmd, env=cmd_env, cwd=os.path.dirname(__file__)) 234 subprocess.check_call(cmd, env=cmd_env, cwd=os.path.dirname(__file__))
234 235
235 package = os.path.join(manifold_folder, 'package', 236 package = os.path.join(manifold_folder, 'package',
236 'edgeExtension.appx') 237 'edgeExtension.appx')
237 238
238 shutil.copyfile(package, outfile) 239 shutil.copyfile(package, outfile)
239 finally: 240 finally:
240 shutil.rmtree(tmp_dir, ignore_errors=True) 241 shutil.rmtree(tmp_dir, ignore_errors=True)
OLDNEW
« no previous file with comments | « no previous file | tests/expecteddata/AppxManifest_edge_development_build.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld