Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29987585: Issue 7232 - Move third-party request check into adblockpluscore (Closed)

Created:
Jan. 23, 2019, 2:52 a.m. by Manish Jethani
Modified:
Jan. 23, 2019, 4:31 a.m.
Reviewers:
Sebastian Noack, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adjust JSDoc #

Total comments: 1

Patch Set 3 : Add tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -2 lines) Patch
M lib/domain.js View 1 2 chunks +43 lines, -2 lines 0 comments Download
A test/domain.js View 1 2 1 chunk +122 lines, -0 lines 1 comment Download

Messages

Total messages: 3
Manish Jethani
Jan. 23, 2019, 2:52 a.m. (2019-01-23 02:52:30 UTC) #1
Manish Jethani
Patch Sets 1-3 Please see issue description in the Trac ticket. https://codereview.adblockplus.org/29987585/diff/29987586/lib/domain.js File lib/domain.js (right): ...
Jan. 23, 2019, 3:25 a.m. (2019-01-23 03:25:26 UTC) #2
Sebastian Noack
Jan. 23, 2019, 4:06 a.m. (2019-01-23 04:06:11 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld