Issue 7230 - python-abp line2dict vectorization

abp/filters/rpy.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 77 matching lines @@
     Returns
     -------
     dict
         With the parsing results and all strings converted to utf8 byte
         strings.
 
     """
     return strings2utf8(tuple2dict(parse_line(text, mode)))
 
 
-def lines2dict(string_list, mode='start'):
+def lines2dicts(string_list, mode='body'):
     """Convert a list of filterlist strings to a dictionary.
 
     All strings in the output dictionary will be UTF8 byte strings. This is
     necessary to prevent unicode encoding errors in rPython conversion layer.
 
     Parameters
     ----------
     string_list: iterable of str
-        Each string in the list can be a header, metadata, empty line,
-        include instruction, or filter.
+        Each string in the list can be an empty line, include instruction, or
+        filter. If the mode is 'start', headers and metadata can also be
+        parsed.
     mode: str
-        Parsing mode. Note: The default is 'start' in case any of the filters

[Vasily Kuznetsov, 2019/01/24 13:27:59]

I think the default should be 'body'. The data team are doing their own parsing
of header and metadata, so in their use case this function will likely only see
filter lines. Also this would be consistent with the behavior of `line2dict`,
which we want to "vectorize" here.

[rhowell, 2019/01/25 00:30:07]

Done.

-        are a header or metadata. For more information, see
-        `abp.filters.parser.parse_line`
+        Parsing mode (see `abp.filters.parser.parse_line`).
 
     Returns
     -------
-    dict

[Vasily Kuznetsov, 2019/01/24 13:27:59]

If I understand it right, the output should be a list of dicts, not dict of
dicts. The idea of this function was to move the loop (line 122) from R to
Python to avoid going through the bridge at each iteration. The final product
that Stephan needs is a list again.

[rhowell, 2019/01/25 00:30:07]

Done.

+    list of dict
         With the parsing results and all strings converted to utf8 byte
         strings.
 
     """
-    result = {}
+    result = []
     for string in string_list:
-        result[string] = line2dict(string, mode)
+        result.append(line2dict(string, mode))
     return result