Issue 7230 - python-abp line2dict vectorization

tests/test_rpy.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 """Functional tests for testing rPython integration."""
 from __future__ import unicode_literals
 
 from collections import namedtuple
 import pytest
 import sys
 
-from abp.filters.rpy import tuple2dict, line2dict, lines2dict
+from abp.filters.rpy import tuple2dict, line2dict, lines2dicts
 
 
 _SAMPLE_TUPLE = namedtuple('tuple', 'foo,bar')
 
 _TEST_EXAMPLES = {
     'header': {
         'in': b'[Adblock Plus 2.0]',
         'out': {
             b'type': b'Header',
             b'version': b'Adblock Plus 2.0',
@@ skipping 108 matching lines @@
     """Test that the API result has the appropriate format.
 
     Checks for both keys and datatypes.
     """
     position = 'start' if line_type in {'header', 'metadata'} else 'body'
     data = line2dict(_TEST_EXAMPLES[line_type]['in'], position)
 
     assert data == _TEST_EXAMPLES[line_type]['out']
 
 
-def test_lines2dict():
-    """Test that the API result has the appropriate format.
+def test_lines2dicts_start_mode():
+    """Test that the API returns the correct result in the appropriate format.
 
-    Checks for both keys and datatypes.
+    Checks for 'start' mode, which can handle headers and metadata.
     """
-    string_list = []
-    line_types = {b'EmptyLine': 'empty', b'Filter': 'filter_single',
-                  b'Comment': 'comment', b'Include': 'include',
-                  b'Header': 'header', b'Metadata': 'metadata'}
+    tests = [t for t in _TEST_EXAMPLES.values()]
+    ins = [ex['in'] for ex in tests]
+    outs = [ex['out'] for ex in tests]
 
-    for key in _TEST_EXAMPLES.keys():
-        string_list.append(_TEST_EXAMPLES[key]['in'])
+    assert lines2dicts(ins, 'start') == outs
 
-    result_dict = lines2dict(string_list)
 
-    for line in result_dict.keys():
-        line_type = line_types[result_dict[line][b'type']]
-        data = line2dict(_TEST_EXAMPLES[line_type]['in'], 'start')
+def test_lines2dicts_default():
+    """Test that the API returns the correct result in the appropriate format.
 
-        assert data == _TEST_EXAMPLES[line_type]['out']
+    By default, lines2dicts() does not correctly parse headers and metadata.
+    """
+    tests = [t for t in _TEST_EXAMPLES.values()
+             if t['out'][b'type'] not in {b'Header', b'Metadata'}]
+    ins = [ex['in'] for ex in tests]
+    outs = [ex['out'] for ex in tests]
+
+    assert lines2dicts(ins) == outs