Issue 7230 - python-abp line2dict vectorization

tests/test_rpy.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 131 matching lines @@
     """Test that the API result has the appropriate format.
 
     Checks for both keys and datatypes.
     """
     position = 'start' if line_type in {'header', 'metadata'} else 'body'
     data = line2dict(_TEST_EXAMPLES[line_type]['in'], position)
 
     assert data == _TEST_EXAMPLES[line_type]['out']
 
 
-def test_lines2dicts():
+def test_lines2dicts_start_mode():
     """Test that the API returns the correct result in the appropriate format.
 
-    Checks for both modes: 'start', and 'body' (the default).
+    Checks for 'start' mode, which can handle headers and metadata.
     """
-    test_start = [t for t in _TEST_EXAMPLES.values()]
-    ins = [ex['in'] for ex in test_start]
-    outs = [ex['out'] for ex in test_start]
+    tests = [t for t in _TEST_EXAMPLES.values()]
+    ins = [ex['in'] for ex in tests]
+    outs = [ex['out'] for ex in tests]
 
     assert lines2dicts(ins, 'start') == outs
 
-    test_body = [t for t in _TEST_EXAMPLES.values()

[Vasily Kuznetsov, 2019/01/28 17:47:36]

What do you think about separating this part into a separate test? Would be
useful to have more granularity of test run results and it seems quite
independent from everything above.

[rhowell, 2019/01/29 01:44:48]

Done.

-                 if t['out'][b'type'] not in {b'Header', b'Metadata'}]
-    ins = [ex['in'] for ex in test_body]
-    outs = [ex['out'] for ex in test_body]
+
+def test_lines2dicts_default():
+    """Test that the API returns the correct result in the appropriate format.
+
+    By default, lines2dicts() does not correctly parse headers and metadata.
+    """
+    tests = [t for t in _TEST_EXAMPLES.values()
+             if t['out'][b'type'] not in {b'Header', b'Metadata'}]
+    ins = [ex['in'] for ex in tests]
+    outs = [ex['out'] for ex in tests]
 
     assert lines2dicts(ins) == outs