Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(210)

Issue 29990559: Noissue - Avoid redundant lookup of whitelist CSP filter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 4 weeks ago by Manish Jethani
Modified:
6 months, 4 weeks ago
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

The additional lookup is redundant if the filter returned originally is a whitelist filter, because specificity does not matter for whitelist filters.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/csp.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Manish Jethani
6 months, 4 weeks ago (2019-01-25 12:31:03 UTC) #1
Manish Jethani
Patch Set 1 The additional lookup is redundant if the filter returned originally is a ...
6 months, 4 weeks ago (2019-01-25 12:32:12 UTC) #2
kzar
6 months, 4 weeks ago (2019-01-25 12:33:35 UTC) #3
Good point, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5