Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29990559: Noissue - Avoid redundant lookup of whitelist CSP filter (Closed)

Created:
Jan. 25, 2019, 12:30 p.m. by Manish Jethani
Modified:
Jan. 25, 2019, 12:43 p.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

The additional lookup is redundant if the filter returned originally is a whitelist filter, because specificity does not matter for whitelist filters.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/csp.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Manish Jethani
Jan. 25, 2019, 12:31 p.m. (2019-01-25 12:31:03 UTC) #1
Manish Jethani
Patch Set 1 The additional lookup is redundant if the filter returned originally is a ...
Jan. 25, 2019, 12:32 p.m. (2019-01-25 12:32:12 UTC) #2
kzar
Jan. 25, 2019, 12:33 p.m. (2019-01-25 12:33:35 UTC) #3
Good point, LGTM

Powered by Google App Engine
This is Rietveld