Issue 7243 - Update adblockpluscore dependency to hg:e26e122e0702

qunit/tests/url.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 {
-  const {extractHostFromFrame, isThirdParty} = require("../../lib/url");
+  const {isThirdParty} = require("../../adblockpluscore/lib/domain");

[Sebastian Noack, 2019/01/30 19:54:25]

Shouldn't we rather remove the isThridParty() checks altogether now? We
generally don't test functions from core directly here. They should be tested
within adblockpluscore instead.

[Manish Jethani, 2019/01/31 01:04:14]

Done.

+  const {extractHostFromFrame} = require("../../lib/url");
   const {platform} = require("info");
 
   QUnit.module("URL/host tools");
 
   test("Extracting hostname from frame", () =>
   {
     function testFrameHostname(hierarchy, expectedHostname, message)
     {
       let frame = null;
 
@@ skipping 101 matching lines @@
     testThirdParty(
       "[::ffff:192.0.2.128]", "[::ffff:192.1.2.128]", true,
       "different IPv4-mapped IPv6 address is third-party"
     );
     testThirdParty("xn--f-1gaa.com", "f\u00f6\u00f6.com", false,
                    "same IDN isn't third-party");
     testThirdParty("example.com..", "example.com....", false,
                    "traling dots are ignored");
   });
 }