Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29993591: Noissue - Add tests for base domain extraction (Closed)

Created:
Jan. 30, 2019, 6:26 p.m. by Manish Jethani
Modified:
Feb. 2, 2019, 5:05 a.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add tests for cascading offsets #

Patch Set 3 : Add one more test for cascading offsets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
M test/domain.js View 1 2 2 chunks +98 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
Jan. 30, 2019, 6:26 p.m. (2019-01-30 18:26:42 UTC) #1
Manish Jethani
Patch Set 1 These are some separate tests specifically for the getDomain function in lib/domain.js
Jan. 30, 2019, 6:27 p.m. (2019-01-30 18:27:57 UTC) #2
Manish Jethani
Patch Sets 2-3 Added some tests for cascading offsets.
Jan. 31, 2019, 3:47 a.m. (2019-01-31 03:47:13 UTC) #3
Manish Jethani
Feb. 2, 2019, 5:05 a.m. (2019-02-02 05:05:44 UTC) #4
Message was sent while issue was closed.
Moved to https://codereview.adblockplus.org/29993591/

Powered by Google App Engine
This is Rietveld