sitescripts/reports/__init__.py - Issue 29993614: Issue 2267 - Unify form handling by reusing form_handler()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: sitescripts/reports/init.py

Issue 29993614: Issue 2267 - Unify form handling by reusing form_handler() (Closed) Base URL: https://hg.adblockplus.org/sitescripts/

Patch Set: Get the tests (clumsily) working Created Feb. 2, 2019, 5:39 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 import pymysql
	Vasily Kuznetsov 2019/02/04 17:48:50 If we only use pymysql instead of MySQLdb for test If we only use pymysql instead of MySQLdb for testing, this import should be done in the tests. P.S. We might want to switch to pymysql in general (given that MySQLdb seems to be dead and doesn't support Python 3, this might be a good idea...) but this would need a separate ticket and review and then it would make more sense to put this import into reports/utils.py instead of here.
	2 pymysql.install_as_MySQLdb()

OLD	NEW