Issue 2267 - Unify form handling by reusing form_handler()

sitescripts/reports/web/updateReport.py

Index: sitescripts/reports/web/updateReport.py
===================================================================
--- a/sitescripts/reports/web/updateReport.py
+++ b/sitescripts/reports/web/updateReport.py
@@ -14,43 +14,45 @@
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import re
-import os
-import sys
 import random
-from urlparse import parse_qsl
-from sitescripts.utils import get_config, get_template, setupStderr
-from sitescripts.web import url_handler
-from sitescripts.reports.utils import calculateReportSecret, calculateReportSecret_compat, getReport, saveReport, sendUpdateNotification, getUserId, updateUserUsefulness
+from sitescripts.utils import get_config, get_template, encode_email_address
+from sitescripts.web import url_handler, form_handler, send_simple_response
+from sitescripts.reports.utils import (calculateReportSecret,
+                                       calculateReportSecret_compat, getReport,
+                                       saveReport, sendUpdateNotification,
+                                       getUserId, updateUserUsefulness)
 
 
 @url_handler('/updateReport')
-def handleRequest(environ, start_response):
-    setupStderr(environ['wsgi.errors'])
-
-    if environ['REQUEST_METHOD'].upper() != 'POST' or not environ.get('CONTENT_TYPE', '').startswith('application/x-www-form-urlencoded'):
-        return showError('Unsupported request method', start_response)
+@form_handler
+def handleRequest(environ, start_response, data):
+    params = {name: data.get(name, '').strip() for name in ['name', 'email',

[Vasily Kuznetsov, 2019/02/07 20:19:16]

These checks were not there before, right? If this is so, this would be new and
not completely related functionality. Maybe it's better to put these changes
into a separate change just to make things more clear. What do you think?

[rhowell, 2019/02/08 01:34:51]

Actually, it seems that most of these params are not mandatory anyway. (I think
only `guid` and `secret` are mandatory.) I was looking at formmail.py and
thinking it was updateReport.py. Oops, that's where my confusion came from.
Sorry!

https://codereview.adblockplus.org/5717434384252928/diff/5747976207073280/sit...

+              'subject', 'message', 'guid', 'secret', 'status', 'usefulness',

[Vasily Kuznetsov, 2019/02/07 20:19:16]

What do you think about putting this list of fields into a constant at the start
of the module? Would be a bit more organized and this line wouldn't have to be
broken so much.

[rhowell, 2019/02/08 01:34:52]

Turns out, we don't need this list for anything!

[Vasily Kuznetsov, 2019/02/08 19:06:07]

Acknowledged.

+                                                            'notify']}
+    missing = [k for k, v in params.iteritems() if not v]
+    if missing:
+        text = 'Missing fields: ' + ', '.join(missing)
+        return send_simple_response(start_response, 400, text)
 
     try:
-        request_body_length = int(environ['CONTENT_LENGTH'])
-    except:
-        return showError('Invalid or missing Content-Length header', start_response)
-
-    request_body = environ['wsgi.input'].read(request_body_length)
-    params = {}
-    for key, value in parse_qsl(request_body):
-        params[key] = value.decode('utf-8')
+        params['email'] = encode_email_address(params['email'])
+    except ValueError:
+        return send_simple_response(start_response, 400,
+                                    'Invalid email address')
 
     guid = params.get('guid', '').lower()
-    if not re.match(r'^[\da-f]{8}-[\da-f]{4}-[\da-f]{4}-[\da-f]{4}-[\da-f]{12}$', guid):
+    guid_regex = r'^[\da-f]{8}-[\da-f]{4}-[\da-f]{4}-[\da-f]{4}-[\da-f]{12}$'

[Vasily Kuznetsov, 2019/02/07 20:19:16]

This could also be a constant at the top of the module.

[rhowell, 2019/02/08 01:34:52]

Done.

+    if not re.match(guid_regex, guid):
         return showError('Invalid or missing report GUID', start_response)
 
     reportData = getReport(guid)
 
-    if reportData == None:
+    if reportData is None:
         return showError('Report does not exist', start_response)
 
     secret = calculateReportSecret(guid)
-    if params.get('secret', '') != secret and params.get('secret', '') != calculateReportSecret_compat(guid):
+    if (params.get('secret', '') != secret and
+       params.get('secret', '') != calculateReportSecret_compat(guid)):
         return showError('Wrong secret value', start_response)
 
     reportData['status'] = params.get('status', '')
@@ -59,8 +61,10 @@
 
     oldusefulness = reportData.get('usefulness', '0')
     reportData['usefulness'] = params.get('usefulness', '0')
+
     if 'email' in reportData:
-        updateUserUsefulness(getUserId(reportData['email']), reportData['usefulness'], oldusefulness)
+        updateUserUsefulness(getUserId(reportData['email']),
+                             reportData['usefulness'], oldusefulness)
 
     saveReport(guid, reportData)
 
@@ -84,5 +88,6 @@
 
 def showError(message, start_response):
     template = get_template(get_config().get('reports', 'errorTemplate'))
-    start_response('400 Processing Error', [('Content-Type', 'application/xhtml+xml; charset=utf-8')])
+    start_response('400 Processing Error',
+                   [('Content-Type', 'application/xhtml+xml; charset=utf-8')])
     return [template.render({'message': message}).encode('utf-8')]