Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: icons/abp-38.png
Issue
29995555
:
Issue 7253 - Pre-render icons for badge on Chromium (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Remove 19x19 and 38x38 icons entirely
Created Feb. 3, 2019, 8:28 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Restrict to Chromium
Patch Set 3: Use only 16x16 and 32x32 icons
Patch Set 4: Update comment
Patch Set 5: Update for loop
Patch Set 6: Use iconPath and iconImageData separately
Patch Set 7: Do not use 19x19 and 38x38 icons on any platform
Patch Set 8: Remove 19x19 and 38x38 icons entirely
Patch Set 9: Remove icons from metadata.chrome
Patch Set 10: Rebase on Rietveld patch 29997602
Patch Set 11: Split into two methods
Patch Set 12: Rewrite renderIcons
Right:
Patch Set 1: None
Patch Set 2: Restrict to Chromium
Patch Set 3: Use only 16x16 and 32x32 icons
Patch Set 4: Update comment
Patch Set 5: Update for loop
Patch Set 6: Use iconPath and iconImageData separately
Patch Set 7: Do not use 19x19 and 38x38 icons on any platform
Patch Set 8: Remove 19x19 and 38x38 icons entirely
Patch Set 9: Remove icons from metadata.chrome
Patch Set 10: Rebase on Rietveld patch 29997602
Patch Set 11: Split into two methods
Patch Set 12: Rewrite renderIcons
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
ext/background.js
icons/abp-19.png
icons/abp-19-notification-critical.png
icons/abp-19-notification-information.png
icons/abp-19-whitelisted.png
icons/abp-38.png
icons/abp-38-notification-critical.png
icons/abp-38-notification-information.png
icons/abp-38-whitelisted.png
lib/icon.js
View unified diff
|
Download patch
« no previous file with comments
|
« icons/abp-19-whitelisted.png
('k') |
icons/abp-38-notification-critical.png »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« icons/abp-19-whitelisted.png
('k') |
icons/abp-38-notification-critical.png »
('j') |
no next file with comments »
Edit Message
Issue 29995555: Issue 7253 - Pre-render icons for badge on Chromium (Closed)
Created Feb. 1, 2019, 2:28 p.m. by Manish Jethani
Modified Feb. 3, 2019, 11:09 a.m.
Reviewers: Sebastian Noack
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Comments: 21
This is Rietveld