Issue 7253 - Pre-render icons for badge on Chromium

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 387 matching lines @@
           this._changes = null;
         }).catch(() =>
         {
           // If the tab is prerendered, browser.browserAction.set* fails
           // and we have to delay our changes until the currently visible tab
           // is replaced with the prerendered tab.
           browser.tabs.onReplaced.addListener(onReplaced);
         });
       }
     },
-    setIcon(path, imageData = null)
-    {
-      // Use ImageData if available.
-      if (imageData)

[Sebastian Noack, 2019/02/03 08:47:16]

Maybe it would be better, to just have two different methods than this switch.

[Manish Jethani, 2019/02/03 09:10:22]

Done.

-        this._addChange("iconImageData", imageData);
-      else
-        this._addChange("iconPath", path);
+    setIconPath(path)
+    {
+      this._addChange("iconPath", path);
+    },
+    setIconImageData(imageData)
+    {
+      this._addChange("iconImageData", imageData);
     },
     setBadge(badge)
     {
       if (!badge)
       {
         this._addChange("badgeText", "");
       }
       else
       {
         if ("number" in badge)
@@ skipping 104 matching lines @@
           return frames.get(0) || null;
         }
       };
     }
 
     return ext.onMessage._dispatch(
       message, sender, sendResponse
     ).includes(true);
   });
 }