Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browser/snippets.js

Issue 29995559: Issue 7236 - Handle sub properties in abort-on-property snippets (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: don't return a value from wrapProperty and unconditionally create error handler. Created March 6, 2019, 9:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/content/snippets.js ('K') | « lib/content/snippets.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/snippets.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/test/browser/snippets.js
@@ -0,0 +1,128 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+"use strict";
+
+const library = require("../../lib/content/snippets.js");
+
+// We need this stub for the injector.
+window.browser =
+{
+ runtime:
+ {
+ getURL: () => ""
+ }
+};
+
+let testDocument = null;
+
+exports.setUp = function(callback)
+{
+ let iframe = document.createElement("iframe");
+ document.body.appendChild(iframe);
+ testDocument = iframe.contentDocument;
+
+ callback();
+};
+
+exports.tearDown = function(callback)
+{
+ let iframe = testDocument.defaultView.frameElement;
+ iframe.parentNode.removeChild(iframe);
+ testDocument = null;
+
+ callback();
+};
+
+function timeout(delay)
+{
+ return new Promise((resolve, reject) =>
+ {
+ window.setTimeout(resolve, delay);
+ });
+}
+
+async function runSnippet(test, snippetName, ...args)
+{
+ let snippet = library[snippetName];
+
+ test.ok(snippet);
+
+ snippet(...args);
+ await timeout(100);
+}
+
+exports.testAbortPropertyReadSnippet = async function(test)
+{
+ window.abpTest = "foo";
+
+ async function testProperty(property, result = true)
+ {
+ let properties = property.split(".");
+ test.ok(properties.length >= 1);
+
+ let exceptionCaught = false;
+ let value = 1;
+ try
+ {
+ let obj = window;
+ while (properties.length > 1)
+ obj = obj[properties.shift()];
+ value = obj[properties.shift()];
+ }
+ catch (e)
+ {
+ if (properties.length == 0)
+ exceptionCaught = true;
+ }
+ test.equal(exceptionCaught, result, `The property "${property}" didn't trigger and exception.`);
+ test.equal(value, result ? 1 : undefined, `The value for "${property}" shouldn't have been read.`);
+ }
+
+ await runSnippet(test, "abort-on-property-read", "abpTest");
+ await testProperty("abpTest");
+
+ window.abpTest2 = {prop1: "foo"};
+
+ await runSnippet(test, "abort-on-property-read", "abpTest2.prop1");
+ await testProperty("abpTest2.prop1");
+
+ // Test that we try to catch a property that don't exist yet.
+ await runSnippet(test, "abort-on-property-read", "abpTest3.prop1");
+ window.abpTest3 = {prop1: "foo"};
+ await testProperty("abpTest3.prop1");
+
+ // Test that other properties don't trigger.
+ await testProperty("abpTest3.prop2", false);
+
+ // Test overwriting the object with another object
+ window.foo = {bar: {}};
+ await runSnippet(test, "abort-on-property-read", "foo.bar.lambda");
+ await testProperty("foo.bar.lambda");
+ window.foo.bar = {};
+ await testProperty("foo.bar.lambda");
+
+ // Test if we start with a non-object
+ window.foo2 = 5;
+ await runSnippet(test, "abort-on-property-read", "foo2.bar2.lambda");
+ await testProperty("foo2.bar2.lambda");
+ window.foo2 = {};
+ await testProperty("foo2.bar2.lambda");
+
+ test.done();
+};
+
« lib/content/snippets.js ('K') | « lib/content/snippets.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld