Issue 29995563: Noissue - Remove unnecessary stack trace

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29995563: Noissue - Remove unnecessary stack trace (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 months, 3 weeks ago by Manish Jethani

Modified:
6 months, 3 weeks ago

Reviewers:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockpluschrome/

Visibility:
Public.

More Reviews

Description

This additional stack trace is generated for every wrapped API call. While useful in theory, it has not been of much help in practice. It slows the API calls down. For history, see: https://issues.adblockplus.org/ticket/4579 https://hg.adblockplus.org/adblockpluschrome/rev/dfc145d98906

Patch Set 1 #

Created: 6 months, 3 weeks ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	polyfill.js	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages