Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29995563: Noissue - Remove unnecessary stack trace (Closed)

Created:
Feb. 2, 2019, 4:05 a.m. by Manish Jethani
Modified:
Feb. 2, 2019, 5:08 a.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

This additional stack trace is generated for every wrapped API call. While useful in theory, it has not been of much help in practice. It slows the API calls down. For history, see: https://issues.adblockplus.org/ticket/4579 https://hg.adblockplus.org/adblockpluschrome/rev/dfc145d98906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M polyfill.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
Feb. 2, 2019, 4:05 a.m. (2019-02-02 04:05:55 UTC) #1
Manish Jethani
Patch Set 1 See description.
Feb. 2, 2019, 4:11 a.m. (2019-02-02 04:11:28 UTC) #2
Sebastian Noack
Feb. 2, 2019, 4:54 a.m. (2019-02-02 04:54:20 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld