Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29996582: Issue 7257 - Throttle badge updates (Closed)

Created:
Feb. 2, 2019, 7:02 p.m. by Manish Jethani
Modified:
Feb. 4, 2019, 8:20 a.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 : #

Total comments: 12

Patch Set 2 : Move Scheduler to lib/stats.js #

Patch Set 3 : Alternative implementation, update all active tabs #

Total comments: 6

Patch Set 4 : Check for undefined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -10 lines) Patch
M lib/stats.js View 1 2 3 1 chunk +61 lines, -10 lines 0 comments Download

Messages

Total messages: 9
Manish Jethani
Feb. 2, 2019, 7:02 p.m. (2019-02-02 19:02:23 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29996582/diff/29997558/lib/stats.js File lib/stats.js (right): https://codereview.adblockplus.org/29996582/diff/29997558/lib/stats.js#newcode30 lib/stats.js:30: const badgeRefreshRate = 4; I found ...
Feb. 3, 2019, 1:20 p.m. (2019-02-03 13:20:21 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29996582/diff/29997558/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29996582/diff/29997558/ext/background.js#newcode548 ext/background.js:548: }; Please don't add new stuff to ext.*, we ...
Feb. 3, 2019, 11:18 p.m. (2019-02-03 23:18:04 UTC) #3
Manish Jethani
Patch Set 2: Move Scheduler to lib/stats.js https://codereview.adblockplus.org/29996582/diff/29997558/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29996582/diff/29997558/ext/background.js#newcode548 ext/background.js:548: }; On ...
Feb. 4, 2019, 5:33 a.m. (2019-02-04 05:33:04 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29996582/diff/29997558/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29996582/diff/29997558/ext/background.js#newcode548 ext/background.js:548: }; On 2019/02/04 05:33:03, Manish Jethani wrote: > On ...
Feb. 4, 2019, 6:32 a.m. (2019-02-04 06:32:04 UTC) #5
Manish Jethani
Patch Set 3: Alternative implementation, update all active tabs This is an alternative implementation that ...
Feb. 4, 2019, 6:57 a.m. (2019-02-04 06:57:17 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29996582/diff/29998557/lib/stats.js File lib/stats.js (right): https://codereview.adblockplus.org/29996582/diff/29998557/lib/stats.js#newcode29 lib/stats.js:29: // 4 fps. Nit: This comment seems somewhat redundant. ...
Feb. 4, 2019, 7:16 a.m. (2019-02-04 07:16:41 UTC) #7
Manish Jethani
Patch Set 4: Check for undefined https://codereview.adblockplus.org/29996582/diff/29998557/lib/stats.js File lib/stats.js (right): https://codereview.adblockplus.org/29996582/diff/29998557/lib/stats.js#newcode29 lib/stats.js:29: // 4 fps. ...
Feb. 4, 2019, 7:36 a.m. (2019-02-04 07:36:14 UTC) #8
Sebastian Noack
Feb. 4, 2019, 8:04 a.m. (2019-02-04 08:04:07 UTC) #9
LGTM

Powered by Google App Engine
This is Rietveld