ext/background.js - Issue 29997602: Issue 7256 - Stop using 19x19 and 38x38 icons

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ext/background.js

Issue 29997602: Issue 7256 - Stop using 19x19 and 38x38 icons (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Created Feb. 3, 2019, 8:45 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ext/background.js

===================================================================

--- a/ext/background.js

+++ b/ext/background.js

@@ -326,20 +326,18 @@

// Firefox for Android displays the browser action not as an icon but

// as a menu item. There is no icon, but such an option may be added

// in the future.

// https://bugzilla.mozilla.org/show_bug.cgi?id=1331746

if (change == "iconPath" && "setIcon" in browser.browserAction)

{

let path = {

16: this._changes.iconPath.replace("$size", "16"),

- 19: this._changes.iconPath.replace("$size", "19"),

20: this._changes.iconPath.replace("$size", "20"),

32: this._changes.iconPath.replace("$size", "32"),

- 38: this._changes.iconPath.replace("$size", "38"),

40: this._changes.iconPath.replace("$size", "40")

};

try

{

return browser.browserAction.setIcon({tabId: this._tabId, path});

}

catch (e)

{

« no previous file with comments | « no previous file | icons/abp-19.png » ('j') | no next file with comments »