Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/icon.js

Issue 29997602: Issue 7256 - Stop using 19x19 and 38x38 icons (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Feb. 3, 2019, 8:45 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « icons/abp-38-whitelisted.png ('k') | metadata.chrome » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/icon.js
===================================================================
--- a/lib/icon.js
+++ b/lib/icon.js
@@ -83,52 +83,44 @@
});
function renderFrames(notificationType)
{
return Promise.all([
loadImage("icons/abp-16.png"),
loadImage("icons/abp-16-whitelisted.png"),
loadImage("icons/abp-16-notification-" + notificationType + ".png"),
- loadImage("icons/abp-19.png"),
- loadImage("icons/abp-19-whitelisted.png"),
- loadImage("icons/abp-19-notification-" + notificationType + ".png"),
loadImage("icons/abp-20.png"),
loadImage("icons/abp-20-whitelisted.png"),
loadImage("icons/abp-20-notification-" + notificationType + ".png"),
loadImage("icons/abp-32.png"),
loadImage("icons/abp-32-whitelisted.png"),
loadImage("icons/abp-32-notification-" + notificationType + ".png"),
- loadImage("icons/abp-38.png"),
- loadImage("icons/abp-38-whitelisted.png"),
- loadImage("icons/abp-38-notification-" + notificationType + ".png"),
loadImage("icons/abp-40.png"),
loadImage("icons/abp-40-whitelisted.png"),
loadImage("icons/abp-40-notification-" + notificationType + ".png")
]).then(images =>
{
let imageMap = {
16: {base: [images[0], images[1]], overlay: images[2]},
- 19: {base: [images[3], images[4]], overlay: images[5]},
- 20: {base: [images[6], images[7]], overlay: images[8]},
- 32: {base: [images[9], images[10]], overlay: images[11]},
- 38: {base: [images[12], images[13]], overlay: images[14]},
- 40: {base: [images[15], images[16]], overlay: images[17]}
+ 20: {base: [images[3], images[4]], overlay: images[5]},
+ 32: {base: [images[6], images[7]], overlay: images[8]},
+ 40: {base: [images[9], images[10]], overlay: images[11]}
};
let frames = {};
let canvas = document.createElement("canvas");
let context = canvas.getContext("2d");
for (let whitelisted of [false, true])
{
for (let i = 0, opacity = 0; i <= 10; opacity = ++i / 10)
{
let imageData = {};
- let sizes = [16, 19, 20, 32, 38, 40];
+ let sizes = [16, 20, 32, 40];
for (let size of sizes)
{
canvas.width = size;
canvas.height = size;
context.globalAlpha = 1;
context.drawImage(imageMap[size]["base"][whitelisted | 0], 0, 0);
context.globalAlpha = opacity;
context.drawImage(imageMap[size]["overlay"], 0, 0);
« no previous file with comments | « icons/abp-38-whitelisted.png ('k') | metadata.chrome » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld