Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1406)

Issue 30000586: Issue 7265 - Orgnanize request blocking filters by domain (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by Manish Jethani
Modified:
5 months, 1 week ago
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -75 lines) Patch
M lib/filterClasses.js View 1 6 chunks +39 lines, -29 lines 0 comments Download
M lib/matcher.js View 1 7 chunks +185 lines, -43 lines 0 comments Download
M test/filterClasses.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
5 months, 2 weeks ago (2019-02-06 15:19:41 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/30000586/diff/30000587/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/30000586/diff/30000587/lib/matcher.js#newcode310 lib/matcher.js:310: if (map.size > 1 || map instanceof Map) In ...
5 months, 2 weeks ago (2019-02-06 16:30:58 UTC) #2
Manish Jethani
https://codereview.adblockplus.org/30000586/diff/30000587/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/30000586/diff/30000587/lib/matcher.js#newcode310 lib/matcher.js:310: if (map.size > 1 || map instanceof Map) On ...
5 months, 1 week ago (2019-02-06 19:25:05 UTC) #3
Sebastian Noack
LGTM
5 months, 1 week ago (2019-02-07 03:33:12 UTC) #4
Manish Jethani
Patch Set 2: Rebase
5 months, 1 week ago (2019-02-07 03:46:20 UTC) #5
Sebastian Noack
5 months, 1 week ago (2019-02-07 04:01:50 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5