Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 30002580: Noissue - Abstract hostname normalization (Closed)

Created:
Feb. 8, 2019, 10:26 a.m. by Manish Jethani
Modified:
Feb. 8, 2019, 8:55 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -27 lines) Patch
M lib/domain.js View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/elemHide.js View 2 chunks +2 lines, -5 lines 0 comments Download
M lib/filterClasses.js View 3 chunks +3 lines, -11 lines 0 comments Download
M lib/matcher.js View 1 2 chunks +3 lines, -10 lines 0 comments Download
M test/domain.js View 1 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
Feb. 8, 2019, 10:26 a.m. (2019-02-08 10:26:12 UTC) #1
Manish Jethani
Patch Set 1
Feb. 8, 2019, 10:27 a.m. (2019-02-08 10:27:40 UTC) #2
hub
Since you refactor the normalization, I think it would be nice to have tests for ...
Feb. 8, 2019, 5 p.m. (2019-02-08 17:00:56 UTC) #3
Manish Jethani
On 2019/02/08 17:00:56, hub wrote: > Since you refactor the normalization, I think it would ...
Feb. 8, 2019, 7:27 p.m. (2019-02-08 19:27:39 UTC) #4
hub
Feb. 8, 2019, 8:44 p.m. (2019-02-08 20:44:54 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld