Noissue - Abstract hostname normalization

test/domain.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 // Only starting NodeJS 10 that URL is in the global space.
 const {URL} = require("url");
 const {createSandbox} = require("./_common");
 
 const publicSuffixes = require("../data/publicSuffixList.json");
 
+let normalizeHostname = null;
 let isThirdParty = null;
 let getDomain = null;
 
 exports.setUp = function(callback)
 {
   let sandboxedRequire = createSandbox({
     extraExports: {
       domain: ["getDomain"]
     }
   });
   (
-    {isThirdParty, getDomain} = sandboxedRequire("../lib/domain")
+    {normalizeHostname, isThirdParty,
+     getDomain} = sandboxedRequire("../lib/domain")
   );
 
   callback();
 };
 
 function hostnameToURL(hostname)
 {
   return new URL("http://" + hostname);
 }
 
 function testThirdParty(test, requestHostname, documentHostname, expected,
                         message)
 {
   test.equal(
     isThirdParty(
       hostnameToURL(requestHostname),
 
       // Chrome's URL object normalizes IP addresses. So some test
       // will fail if we don't normalize the document host as well.
       hostnameToURL(documentHostname).hostname
     ),
     expected,
     message
   );
 }
+
+exports.testNormalizeHostname = function(test)
+{
+  test.equal(normalizeHostname("example.com"), "example.com");
+  test.equal(normalizeHostname("example.com."), "example.com");
+  test.equal(normalizeHostname("example.com.."), "example.com");
+  test.equal(normalizeHostname("example.com..."), "example.com");
+
+  test.equal(normalizeHostname("Example.com"), "example.com");
+  test.equal(normalizeHostname("ExaMple.Com"), "example.com");
+  test.equal(normalizeHostname("ExaMple.Com.."), "example.com");
+
+  test.equal(normalizeHostname("192.168.1.1"), "192.168.1.1");
+  test.equal(normalizeHostname("192.168.1.1."), "192.168.1.1");
+
+  test.equal(normalizeHostname("2001:0db8:85a3:0000:0000:8a2e:0370:7334"),
+             "2001:0db8:85a3:0000:0000:8a2e:0370:7334");
+  test.equal(normalizeHostname("2001:0db8:85a3:0000:0000:8a2e:0370:7334."),
+             "2001:0db8:85a3:0000:0000:8a2e:0370:7334");
+  test.equal(normalizeHostname("2001:0DB8:85A3:0000:0000:8A2E:0370:7334"),
+             "2001:0db8:85a3:0000:0000:8a2e:0370:7334");
+
+  test.done();
+};
 
 exports.testIsThirdParty = function(test)
 {
   testThirdParty(test, "foo", "foo", false, "same domain isn't third-party");
   testThirdParty(test, "foo", "bar", true, "different domain is third-party");
   testThirdParty(test, "foo.com", "foo.com", false,
                  "same domain with TLD (.com) isn't third-party");
   testThirdParty(test, "foo.com", "bar.com", true,
                  "same TLD (.com) but different domain is third-party");
   testThirdParty(test, "foo.com", "www.foo.com", false,
@@ skipping 138 matching lines @@
             "example.us-east-1.amazonaws.com");
   test.equal(getDomain("us-east-1.amazonaws.com"), "us-east-1.amazonaws.com");
   test.equal(getDomain("example.amazonaws.com"), "amazonaws.com");
   test.equal(getDomain("amazonaws.com"), "amazonaws.com");
 
   // Edge case.
   test.equal(getDomain(""), "");
 
   test.done();
 };