Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 30002586: Issue 7269 - Restrict URL rewrites to GETs only (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 1 week ago by Manish Jethani
Modified:
9 months, 1 week ago
Reviewers:
a.giammarchi
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

There are a few HTTP methods: https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods URL rewriting was only intended for GET requests. We should stop doing it for other requests.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M lib/requestBlocker.js View 1 chunk +8 lines, -5 lines 4 comments Download

Messages

Total messages: 15
Manish Jethani
9 months, 1 week ago (2019-02-08 12:01:22 UTC) #1
Manish Jethani
Patch Set 1
9 months, 1 week ago (2019-02-08 12:03:55 UTC) #2
a.giammarchi
I have tested this and it works as expected. Beside the minor comment that shouldn't ...
9 months, 1 week ago (2019-02-08 12:10:27 UTC) #3
kzar
On 2019/02/08 12:01:22, Manish Jethani wrote: Please can you file an issue for this first?
9 months, 1 week ago (2019-02-08 12:21:18 UTC) #4
hub
https://codereview.adblockplus.org/30002586/diff/30002587/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/30002586/diff/30002587/lib/requestBlocker.js#newcode207 lib/requestBlocker.js:207: result = {redirectUrl: rewrittenUrl}; On 2019/02/08 12:10:27, a.giammarchi wrote: ...
9 months, 1 week ago (2019-02-08 17:05:26 UTC) #5
a.giammarchi
On 2019/02/08 17:05:26, hub wrote: > it is named this way because it is the ...
9 months, 1 week ago (2019-02-08 17:07:32 UTC) #6
Sebastian Noack
Any particular reason to limit this to GET requests? I guess, there is nothing that ...
9 months, 1 week ago (2019-02-08 22:07:59 UTC) #7
a.giammarchi
On 2019/02/08 22:07:59, Sebastian Noack wrote: > Any particular reason to limit this to GET ...
9 months, 1 week ago (2019-02-08 22:59:27 UTC) #8
Sebastian Noack
On 2019/02/08 22:59:27, a.giammarchi wrote: > We had troubles handling OPTIONS requests, in a site ...
9 months, 1 week ago (2019-02-08 23:14:14 UTC) #9
a.giammarchi
On 2019/02/08 23:14:14, Sebastian Noack wrote: > > So I'd ask the question the other ...
9 months, 1 week ago (2019-02-08 23:50:26 UTC) #10
Sebastian Noack
Can you show me an example, how a $rewrite filter works as expected (preventing ads ...
9 months, 1 week ago (2019-02-09 00:07:02 UTC) #11
a.giammarchi
On 2019/02/09 00:07:02, Sebastian Noack wrote: > Can you show me an example, how a ...
9 months, 1 week ago (2019-02-09 06:53:43 UTC) #12
Manish Jethani
On 2019/02/09 06:53:43, a.giammarchi wrote: > On 2019/02/09 00:07:02, Sebastian Noack wrote: > > Can ...
9 months, 1 week ago (2019-02-09 11:28:23 UTC) #13
a.giammarchi
I agree on what's described in the issue so I'd change the logic to early ...
9 months, 1 week ago (2019-02-09 13:27:20 UTC) #14
Manish Jethani
9 months, 1 week ago (2019-02-10 12:18:44 UTC) #15
Removing everyone here for now. Let's take the discussion to the issue tracker.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5