Issue 7284 - Move CSS escaping to createStyleSheet

test/browser/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 284 matching lines @@
 {
   let toHide = createElementWithStyle("{background-color: #000}");
   let selectors = [":-abp-properties(/.*color: rgb\\(0, 0, 0\\)/)"];
 
   if (await applyElemHideEmulation(test, selectors))
     expectHidden(test, toHide);
 
   test.done();
 };
 
-exports.testPropertySelectorWithEscapedBrace = async function(test)

[hub, 2019/02/12 23:55:49]

these two tests are no longer relevant.

[Manish Jethani, 2019/02/13 12:27:25]

Shouldn't we add some tests now to test/elemHide.js to make sure the braces are
being escaped in the generated style sheet?

[hub, 2019/02/13 16:33:32]

Yes

-{
-  let toHide = createElementWithStyle("{background-color: #000}");
-  let selectors = [":-abp-properties(/background.\\7B 0,6\\7D : rgb\\(0, 0, 0\\)/)"];
-
-  if (await applyElemHideEmulation(test, selectors))
-    expectHidden(test, toHide);
-
-  test.done();
-};
-
-exports.testPropertySelectorWithImproperlyEscapedBrace = async function(test)
-{
-  let toHide = createElementWithStyle("{background-color: #000}");
-  let selectors = [":-abp-properties(/background.\\7B0,6\\7D: rgb\\(0, 0, 0\\)/)"];
-
-  if (await applyElemHideEmulation(test, selectors))
-    expectVisible(test, toHide);
-
-  test.done();
-};
-
 exports.testDynamicallyChangedProperty = async function(test)
 {
   let toHide = createElementWithStyle("{}");
   let selectors = [":-abp-properties(background-color: rgb(0, 0, 0))"];
 
   if (await applyElemHideEmulation(test, selectors))
   {
     expectVisible(test, toHide);
     insertStyleRule("#" + toHide.id + " {background-color: #000}");
 
@@ skipping 757 matching lines @@
     {
       if (element.id == "n2" || element.id == "n2_3")
         expectProcessed(test, element, element.id);
       else
         expectNotProcessed(test, element, element.id);
     }
   }
 
   test.done();
 };