Issue 7284 - Move CSS escaping to createStyleSheet

test/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 291 matching lines @@
   test.equal((createStyleSheet(selectors).match(/\n/g) || []).length,
              Math.ceil(50000 / selectorGroupSize),
              "Style sheet should be split up into rules with at most " +
              selectorGroupSize + " selectors each");
 
   test.equal(
     createStyleSheet([
       "html", "#foo", ".bar", "#foo .bar", "#foo > .bar",
       "#foo[data-bar='{foo: 1}']"
     ]),
-    "html, #foo, .bar, #foo .bar, #foo > .bar, #foo[data-bar='\\7B foo: 1\\7D '] " +

[Manish Jethani, 2019/02/16 04:34:04]

Nit: This is the only line in the file that exceeds 80 characters. Can we split
this into ""html, #foo, .bar, #foo .bar, #foo > .bar," and the rest?

[hub, 2019/02/18 12:56:20]

Done.

[Manish Jethani, 2019/02/18 13:07:21]

Nit: When wrapping an expression `a + b` the break should be after `+` and `b`
should be in the same column as `a`.

[hub, 2019/02/18 13:51:08]

Done.

-    "{display: none !important;}\n",
-    "Style sheet creation should work"

[Manish Jethani, 2019/02/16 04:34:04]

"Braces should be escaped"

[hub, 2019/02/18 12:56:20]

Done.

+    "html, #foo, .bar, #foo .bar, #foo > .bar, " +
+    "#foo[data-bar='\\7B foo: 1\\7D '] {display: none !important;}\n",
+    "Braces should be escaped"
   );
+
   test.done();

[Manish Jethani, 2019/02/16 04:34:04]

Nit: Can we leave a blank line above test.done?

[hub, 2019/02/18 12:56:21]

Done.

 };
 
 exports.testRulesFromStyleSheet = function(test)
 {
   // Note: The rulesFromStyleSheet function assumes that each rule will be
   // terminated with a newline character, including the last rule. If this is
   // not the case, the function goes into an infinite loop. It should only be
   // used with the return value of the createStyleSheet function.
 
   test.deepEqual([...rulesFromStyleSheet("")], []);
   test.deepEqual([...rulesFromStyleSheet("#foo {}\n")], ["#foo {}"]);
   test.deepEqual([...rulesFromStyleSheet("#foo {}\n#bar {}\n")],
                  ["#foo {}", "#bar {}"]);
 
   test.done();
 };