Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 30009567: Issue 7295 - Add non-active filters to blocking group (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months ago by Manish Jethani
Modified:
9 months ago
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M lib/subscriptionClasses.js View 1 chunk +1 line, -1 line 0 comments Download
M test/filterStorage.js View 1 chunk +12 lines, -7 lines 1 comment Download

Messages

Total messages: 3
Manish Jethani
9 months ago (2019-02-16 14:17:21 UTC) #1
Manish Jethani
Patch Set 1 See issue description. https://codereview.adblockplus.org/30009567/diff/30009568/test/filterStorage.js File test/filterStorage.js (right): https://codereview.adblockplus.org/30009567/diff/30009568/test/filterStorage.js#newcode261 test/filterStorage.js:261: filterStorage.addFilter(Filter.fromText("example.com#$#foobar")); We still ...
9 months ago (2019-02-16 14:19:23 UTC) #2
hub
9 months ago (2019-02-18 17:28:34 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5