Issue 7290 - Fix signature production in sitekey_frame.py

sitescripts/web.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 21 matching lines @@
         registerUrlHandler(url, func)
         return func
     return decorator
 
 
 def registerUrlHandler(url, func):
     if url in handlers:
         raise Exception('A handler for url %s is already registered' % url)
     handlers[url] = func
 
-# https://www.python.org/dev/peps/pep-0333/#url-reconstruction
-
 
 def request_path(environ, include_query=True):

[Vasily Kuznetsov, 2019/02/19 22:28:53]

This function is not used anywhere else and its logic seems to be causing the
issue so I decided to directly modify it.

[kzar, 2019/02/20 08:12:07]

IMO The change for #7290 should just contain this change, if it's the actual
fix.

Would you mind splitting the other changes out in a Noissue to tidy the
testpages code up? (I'd be happy to review that too if it helps.)

[kzar, 2019/02/21 08:12:25]

But there's still a bunch of other changes in the latest patch set too?

All your changes (from both patch sets) LGTM, I just ask you do push them as two
commits. The first containing this change (`+` to `or`) for 7290. The second
with all the other changes as a no/separate issue.

-    path = urllib.quote(environ.get('SCRIPT_NAME', '') +
+    path = urllib.quote(environ.get('SCRIPT_NAME', '') or
                         environ.get('PATH_INFO', ''))
     query_string = environ.get('QUERY_STRING', '')
     if query_string and include_query:
         path += '?' + urllib.quote(query_string)
     return path
 
 
 def basic_auth(config_section='DEFAULT'):
     def decorator(function):
         def authenticating_wrapper(environ, start_response):
@@ skipping 70 matching lines @@
 
     return handler(environ, start_response)
 
 
 for module in set(get_config().options('multiplexer')) - set(get_config().defaults()):
     module_path = get_config().get('multiplexer', module)
     if module_path:
         imp.load_source(module, module_path)
     else:
         importlib.import_module(module)