Issue 7094 - Link filters with subscriptions in INI parser

test/filterStorage_readwrite.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 165 matching lines @@
 
     let importer = filterStorage.importData();
     for (let line of lines)
       importer(line);
     importer(null);
 
     test.equal(filterStorage.fileProperties.version, filterStorage.formatVersion, "File format version");
 
     let exported = Array.from(filterStorage.exportData());
     test.deepEqual(canonize(exported), canonize(lines), "Import/export result");
+
+    // Make sure the relationships between filters and subscriptions are set
+    // up.
+    for (let subscription of filterStorage.subscriptions())
+    {
+      for (let text of subscription.filterText())
+      {
+        let found = false;
+
+        for (let filterSubscription of Filter.fromText(text).subscriptions())
+        {
+          if (filterSubscription == subscription)
+          {
+            found = true;
+            break;
+          }
+        }
+
+        test.ok(found, "Filter " + JSON.stringify(text) + " " +
+                       "should be linked to its subscription " +
+                       subscription.url);

[hub, 2019/02/22 15:28:04]

I think using a template string here would be clearer.

[Manish Jethani, 2019/02/22 15:48:38]

Done.

+      }
+    }
   }
   catch (error)
   {
     unexpectedError.call(test, error);
   }
 
   test.done();
 };
 
 exports.testSavingWithoutBackups = async function(test)
@@ skipping 97 matching lines @@
 
     test.equal([...filterStorage.subscriptions()][0].filterCount, 1, "Filter count after reloading");
   }
   catch (error)
   {
     unexpectedError.call(test, error);
   }
 
   test.done();
 };