Issue 7029 - Remove subscriptions property of Filter object

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 89 matching lines @@
   /**
    * Filter type as a string, e.g. "blocking".
    * @type {string}
    */
   get type()
   {
     throw new Error("Please define filter type in the subclass");
   },
 
   /**
-   * Yields subscriptions to which the filter belongs.
-   * @yields {Subscription}
-   */
-  *subscriptions()
-  {
-    if (this._subscriptions)
-    {
-      if (this._subscriptions instanceof Set)
-        yield* this._subscriptions;
-      else
-        yield this._subscriptions;
-    }
-  },
-
-  /**
-   * The number of subscriptions to which the filter belongs.
-   * @type {number}
-   */
-  get subscriptionCount()
-  {
-    if (this._subscriptions instanceof Set)
-      return this._subscriptions.size;
-
-    return this._subscriptions ? 1 : 0;
-  },
-
-  /**
-   * Adds a subscription to the set of subscriptions to which the filter
-   * belongs.
-   * @param {Subscription} subscription
-   */
-  addSubscription(subscription)
-  {
-    // Since we use truthy checks in our logic, we must avoid adding a
-    // subscription that isn't a non-null object.
-    if (subscription === null || typeof subscription != "object")
-      return;
-
-    if (this._subscriptions)
-    {
-      if (this._subscriptions instanceof Set)
-        this._subscriptions.add(subscription);
-      else if (subscription != this._subscriptions)
-        this._subscriptions = new Set([this._subscriptions, subscription]);
-    }
-    else
-    {
-      this._subscriptions = subscription;
-    }
-  },
-
-  /**
-   * Removes a subscription from the set of subscriptions to which the filter
-   * belongs.
-   * @param {Subscription} subscription
-   */
-  removeSubscription(subscription)
-  {
-    if (this._subscriptions)
-    {
-      if (this._subscriptions instanceof Set)
-      {
-        this._subscriptions.delete(subscription);
-
-        if (this._subscriptions.size == 1)
-          this._subscriptions = [...this._subscriptions][0];
-      }
-      else if (subscription == this._subscriptions)
-      {
-        this._subscriptions = null;
-      }
-    }
-  },
-
-  /**
    * Serializes the filter for writing out on disk.
    * @yields {string}
    */
   *serialize()
   {
     let {text} = this;
 
     yield "[Filter]";
     yield "text=" + text;
   },
@@ skipping 1242 matching lines @@
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()
   {
     return this.body;
   }
 });