Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/filterStorage_readwrite.js

Issue 30013628: Issue 7029 - Remove subscriptions property of Filter object (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Feb. 24, 2019, 1:30 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/filterStorage_readwrite.js
===================================================================
--- a/test/filterStorage_readwrite.js
+++ b/test/filterStorage_readwrite.js
@@ -178,37 +178,16 @@
for (let line of lines)
importer(line);
importer(null);
test.equal(filterStorage.fileProperties.version, filterStorage.formatVersion, "File format version");
let exported = Array.from(filterStorage.exportData());
test.deepEqual(canonize(exported), canonize(lines), "Import/export result");
-
- // Make sure the relationships between filters and subscriptions are set
Manish Jethani 2019/02/26 12:29:57 This doesn't make sense anymore.
- // up.
- for (let subscription of filterStorage.subscriptions())
- {
- for (let text of subscription.filterText())
- {
- let found = false;
-
- for (let filterSubscription of Filter.fromText(text).subscriptions())
- {
- if (filterSubscription == subscription)
- {
- found = true;
- break;
- }
- }
-
- test.ok(found, `Filter ${text} should be linked to subscription ${subscription.url}`);
- }
- }
}
catch (error)
{
unexpectedError.call(test, error);
}
test.done();
};

Powered by Google App Engine
This is Rietveld