Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(181)

Issue 30018555: Issue 7311 - Split _checkEntryMatchByDomain() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by Manish Jethani
Modified:
7 months, 3 weeks ago
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Avoid unnecessary call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -40 lines) Patch
M lib/matcher.js View 1 2 chunks +54 lines, -40 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
7 months, 3 weeks ago (2019-02-26 09:29:42 UTC) #1
Manish Jethani
Patch Set 1 Splitting up this function makes it perform better on V8. It's also ...
7 months, 3 weeks ago (2019-02-26 09:31:02 UTC) #2
Manish Jethani
Patch Set 2: Avoid unnecessary call
7 months, 3 weeks ago (2019-02-26 10:13:06 UTC) #3
hub
7 months, 3 weeks ago (2019-02-26 23:12:31 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5