Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(279)

Issue 30018560: Issue 7312 - Ignore lone pure generic filters for specific-only queries (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 2 weeks ago by Manish Jethani
Modified:
9 months, 2 weeks ago
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Based on https://codereview.adblockplus.org/30018555/

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Add more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M lib/matcher.js View 4 chunks +13 lines, -10 lines 0 comments Download
M test/matcher.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
9 months, 2 weeks ago (2019-02-26 11:46:52 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/30018560/diff/30018565/lib/matcher.js File lib/matcher.js (left): https://codereview.adblockplus.org/30018560/diff/30018565/lib/matcher.js#oldcode480 lib/matcher.js:480: if (specificOnly && !(filter instanceof WhitelistFilter)) ...
9 months, 2 weeks ago (2019-02-26 11:54:24 UTC) #2
Manish Jethani
Patch Set 2: Add more tests
9 months, 2 weeks ago (2019-02-26 12:00:57 UTC) #3
hub
9 months, 2 weeks ago (2019-02-26 23:27:43 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5