Issue 7321 - Lower-case non-literal patterns for case-insensitive matching

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 706 matching lines @@
     this.matchCase = matchCase;
   if (thirdParty != null)
     this.thirdParty = thirdParty;
   if (sitekeys != null)
     this.sitekeySource = sitekeys;
   if (rewrite != null)
     this.rewrite = rewrite;
   if (resourceName)
     this.resourceName = resourceName;
 
+  if (!this.matchCase)
+    regexpSource = regexpSource.toLowerCase();
+
   if (regexpSource.length >= 2 &&
       regexpSource[0] == "/" &&
       regexpSource[regexpSource.length - 1] == "/")
   {
     // The filter is a regular expression - convert it immediately to
     // catch syntax errors
-    let regexp = new RegExp(regexpSource.substring(1, regexpSource.length - 1),
-                            this.matchCase ? "" : "i");
+    let regexp = new RegExp(regexpSource.substring(1, regexpSource.length - 1));
     Object.defineProperty(this, "regexp", {value: regexp});
   }
   else
   {
     // Patterns like /foo/bar/* exist so that they are not treated as regular
     // expressions. We drop any superfluous wildcards here so our optimizations
     // can kick in.
     if (this.rewrite == null || this.resourceName)
       regexpSource = regexpSource.replace(/^\*+/, "").replace(/\*+$/, "");
 
-    if (!this.matchCase && isLiteralPattern(regexpSource))
-      regexpSource = regexpSource.toLowerCase();
-
     // No need to convert this filter to regular expression yet, do it on demand
     this.pattern = regexpSource;
   }
 }
 exports.RegExpFilter = RegExpFilter;
 
 RegExpFilter.prototype = extend(ActiveFilter, {
   /**
    * Number of filters contained, will always be 1 (required to
    * optimize {@link Matcher}).
@@ skipping 16 matching lines @@
   /**
    * Regular expression to be used when testing against this filter
    * @type {RegExp}
    */
   get regexp()
   {
     let value = null;
 
     let {pattern, rewrite, resourceName} = this;
     if ((rewrite != null && !resourceName) || !isLiteralPattern(pattern))
-    {
-      value = new RegExp(filterToRegExp(pattern, rewrite != null),
-                         this.matchCase ? "" : "i");
-    }
+      value = new RegExp(filterToRegExp(pattern, rewrite != null));
 
     Object.defineProperty(this, "regexp", {value});
     return value;
   },
   /**
    * Content types the filter applies to, combination of values from
    * RegExpFilter.typeMap
    * @type {number}
    */
   contentType: 0x7FFFFFFF,
@@ skipping 93 matching lines @@
   /**
    * Checks whether the given URL matches this filter's pattern.
    * @param {string} location The URL to check.
    * @param {?string} [lowerCaseLocation] The lower-case version of the URL to
    *   check, for case-insensitive matching.
    * @returns {boolean} <code>true</code> if the URL matches.
    * @package
    */
   matchesLocation(location, lowerCaseLocation)
   {
+    if (!this.matchCase)
+      location = lowerCaseLocation || location.toLowerCase();
+
     let {regexp} = this;
 
     if (regexp)
       return regexp.test(location);
 
-    if (!this.matchCase)
-      location = lowerCaseLocation || location.toLowerCase();
-
     let {pattern} = this;
 
     let startsWithDoubleAnchor = pattern[0] == "|" && pattern[1] == "|";
     let endsWithSeparator = pattern[pattern.length - 1] == "^";
 
     if (startsWithDoubleAnchor)
       pattern = pattern.substr(2);
 
     if (endsWithSeparator)
       pattern = pattern.slice(0, -1);
@@ skipping 518 matching lines @@
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()
   {
     return this.body;
   }
 });