Issue 7324 - Simplify logic for domains property

test/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 613 matching lines @@
 exports.testDomainMapDeduplication = function(test)
 {
   let filter1 = Filter.fromText("foo$domain=blocking.example.com");
   let filter2 = Filter.fromText("bar$domain=blocking.example.com");
   let filter3 = Filter.fromText("elemhide.example.com##.foo");
   let filter4 = Filter.fromText("elemhide.example.com##.bar");
 
   // This compares the references to make sure that both refer to the same
   // object (#6815).
 
-  // For both request blocking and element hiding filters, the value of the

[Manish Jethani, 2019/03/04 12:02:54]

The tests are also simplified now.

-  // property is cached internally only on second access.
-  test.notEqual(filter1.domains, filter2.domains);
   test.equal(filter1.domains, filter2.domains);
-  test.notEqual(filter3.domains, filter4.domains);
   test.equal(filter3.domains, filter4.domains);
 
   let filter5 = Filter.fromText("bar$domain=www.example.com");
   let filter6 = Filter.fromText("www.example.com##.bar");
 
   test.notEqual(filter2.domains, filter5.domains);
-
-  // Check twice for element hiding filters to make sure the internal cached
-  // values are also not equal.
-  test.notEqual(filter4.domains, filter6.domains);
   test.notEqual(filter4.domains, filter6.domains);
 
   test.done();
 };