Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 30024555: Issue 7334 - Remove support for callbacks in API wrappers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 2 weeks ago by Manish Jethani
Modified:
6 months, 3 weeks ago
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : Handle calls with no arguments #

Total comments: 7

Patch Set 4 : Remove checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M polyfill.js View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 13
Manish Jethani
8 months, 2 weeks ago (2019-03-06 10:56:12 UTC) #1
Sebastian Noack
LGTM. At the time we couldn't land it because of the adblockplusui still relying on ...
6 months, 3 weeks ago (2019-04-24 09:28:36 UTC) #2
Manish Jethani
On 2019/04/24 09:28:36, Sebastian Noack wrote: > LGTM. > > At the time we couldn't ...
6 months, 3 weeks ago (2019-04-24 14:32:53 UTC) #3
Manish Jethani
Patch Set 2: Rebase Patch Set 3: Handle calls with no arguments https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js File polyfill.js ...
6 months, 3 weeks ago (2019-04-24 14:42:23 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js#newcode120 polyfill.js:120: lastArgumentType == "undefined" && args.length > 0) On 2019/04/24 ...
6 months, 3 weeks ago (2019-04-24 19:50:38 UTC) #5
Manish Jethani
https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js#newcode120 polyfill.js:120: lastArgumentType == "undefined" && args.length > 0) On 2019/04/24 ...
6 months, 3 weeks ago (2019-04-24 20:09:47 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js#newcode120 polyfill.js:120: lastArgumentType == "undefined" && args.length > 0) On 2019/04/24 ...
6 months, 3 weeks ago (2019-04-24 20:42:30 UTC) #7
Manish Jethani
https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js#newcode120 polyfill.js:120: lastArgumentType == "undefined" && args.length > 0) On 2019/04/24 ...
6 months, 3 weeks ago (2019-04-25 08:04:54 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js#newcode120 polyfill.js:120: lastArgumentType == "undefined" && args.length > 0) On 2019/04/25 ...
6 months, 3 weeks ago (2019-04-25 08:18:21 UTC) #9
Manish Jethani
https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js File polyfill.js (right): https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js#newcode120 polyfill.js:120: lastArgumentType == "undefined" && args.length > 0) On 2019/04/25 ...
6 months, 3 weeks ago (2019-04-25 08:51:20 UTC) #10
Manish Jethani
Patch Set 4: Remove checks
6 months, 3 weeks ago (2019-04-25 09:05:19 UTC) #11
Sebastian Noack
On 2019/04/25 08:51:20, Manish Jethani wrote: > https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js > File polyfill.js (right): > > https://codereview.adblockplus.org/30024555/diff/30049559/polyfill.js#newcode120 ...
6 months, 3 weeks ago (2019-04-25 09:05:25 UTC) #12
Sebastian Noack
6 months, 3 weeks ago (2019-04-25 09:08:31 UTC) #13
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5