Issue 6820 - Move tests to mocha

test/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 37 matching lines @@
   function normalizeSelectors(selectors)
   {
     // generateStyleSheetForDomain is currently allowed to return duplicate
     // selectors for performance reasons, so we need to remove duplicates here.
     return selectors.slice().sort().filter((selector, index, sortedSelectors) =>
     {
       return index == 0 || selector != sortedSelectors[index - 1];
     });
   }
 
-  function testResult(domain, expectedSelectors, specificOnly)
+  function testResult(domain, expectedSelectors,
+                      {specificOnly = false, expectedExceptions = []} = {})
   {
     let normalizedExpectedSelectors = normalizeSelectors(expectedSelectors);
 
-    let {code, selectors} =
-        ElemHide.generateStyleSheetForDomain(domain, specificOnly, true);
+    let {code, selectors, exceptions} =
+        ElemHide.generateStyleSheetForDomain(domain, specificOnly, true, true);
 
     assert.deepEqual(normalizeSelectors(selectors), normalizedExpectedSelectors);
+
+    // Test for consistency in exception free case.
+    assert.deepEqual(ElemHide.generateStyleSheetForDomain(
+      domain, specificOnly, true, false), {
+        code,
+        selectors,
+        exceptions: null
+      });
+
+    assert.deepEqual(exceptions.map(({text}) => text), expectedExceptions);
 
     // Make sure each expected selector is in the actual CSS code.
     for (let selector of normalizedExpectedSelectors)
     {
       assert.ok(code.includes(selector + ", ") ||
                 code.includes(selector + " {display: none !important;}\n"));
     }
   }
 
   it("Generating Style Sheet", () =>
@@ skipping 17 matching lines @@
     testResult("", []);
 
     addFilter("foo.example.com##turnip");
     testResult("foo.example.com", ["turnip"]);
     testResult("example.com", ["foo"]);
     testResult("com", []);
     testResult("", []);
 
     addException("example.com#@#foo");
     testResult("foo.example.com", ["turnip"]);
-    testResult("example.com", []);
+    testResult("example.com", [], {
+      expectedExceptions: ["example.com#@#foo"]
+    });
     testResult("com", []);
     testResult("", []);
 
     addFilter("com##bar");
     testResult("foo.example.com", ["turnip", "bar"]);
-    testResult("example.com", ["bar"]);
+    testResult("example.com", ["bar"], {
+      expectedExceptions: ["example.com#@#foo"]
+    });
     testResult("com", ["bar"]);
     testResult("", []);
 
     addException("example.com#@#bar");
-    testResult("foo.example.com", ["turnip"]);
-    testResult("example.com", []);
+    testResult("foo.example.com", ["turnip"], {
+      expectedExceptions: ["example.com#@#bar"]
+    });
+    testResult("example.com", [], {
+      expectedExceptions: ["example.com#@#foo", "example.com#@#bar"]
+    });
     testResult("com", ["bar"]);
     testResult("", []);
 
     removeException("example.com#@#foo");
-    testResult("foo.example.com", ["turnip"]);
-    testResult("example.com", ["foo"]);
+    testResult("foo.example.com", ["turnip"], {
+      expectedExceptions: ["example.com#@#bar"]
+    });
+    testResult("example.com", ["foo"], {
+      expectedExceptions: ["example.com#@#bar"]
+    });
     testResult("com", ["bar"]);
     testResult("", []);
 
     removeException("example.com#@#bar");
     testResult("foo.example.com", ["turnip", "bar"]);
     testResult("example.com", ["foo", "bar"]);
     testResult("com", ["bar"]);
     testResult("", []);
 
     addFilter("##generic");
     testResult("foo.example.com", ["turnip", "bar", "generic"]);
     testResult("example.com", ["foo", "bar", "generic"]);
     testResult("com", ["bar", "generic"]);
     testResult("", ["generic"]);
-    testResult("foo.example.com", ["turnip", "bar"], true);
-    testResult("example.com", ["foo", "bar"], true);
-    testResult("com", ["bar"], true);
-    testResult("", [], true);
+    testResult("foo.example.com", ["turnip", "bar"], {specificOnly: true});
+    testResult("example.com", ["foo", "bar"], {specificOnly: true});
+    testResult("com", ["bar"], {specificOnly: true});
+    testResult("", [], {specificOnly: true});
     removeFilter("##generic");
 
     addFilter("~adblockplus.org##example");
     testResult("adblockplus.org", []);
     testResult("", ["example"]);
     testResult("foo.example.com", ["turnip", "bar", "example"]);
-    testResult("foo.example.com", ["turnip", "bar"], true);
+    testResult("foo.example.com", ["turnip", "bar"], {specificOnly: true});
     removeFilter("~adblockplus.org##example");
 
     removeFilter("~foo.example.com,example.com##foo");
     testResult("foo.example.com", ["turnip", "bar"]);
     testResult("example.com", ["bar"]);
     testResult("com", ["bar"]);
     testResult("", []);
 
     removeFilter("com##bar");
     testResult("foo.example.com", ["turnip"]);
@@ skipping 36 matching lines @@
     testResult("com", ["foo"]);
     testResult("", ["foo"]);
     removeFilter("~example.com##foo");
 
     removeFilter("~foo.example.com,example.com##foo");
 
     // Test criteria
     addFilter("##hello");
     addFilter("~example.com##world");
     addFilter("foo.com##specific");
-    testResult("foo.com", ["specific"], true);
-    testResult("foo.com", ["hello", "specific", "world"], false);
+    testResult("foo.com", ["specific"], {specificOnly: true});
     testResult("foo.com", ["hello", "specific", "world"]);
-    testResult("foo.com.", ["hello", "specific", "world"]);
-    testResult("example.com", [], true);
+    testResult("example.com", [], {specificOnly: true});
     removeFilter("foo.com##specific");
     removeFilter("~example.com##world");
     removeFilter("##hello");
     testResult("foo.com", []);
 
     addFilter("##hello");
-    testResult("foo.com", [], true);
-    testResult("foo.com", ["hello"], false);
-    testResult("foo.com", ["hello"]);
-    testResult("bar.com", [], true);
-    testResult("bar.com", ["hello"], false);
+    testResult("foo.com", [], {specificOnly: true});
+    testResult("foo.com", ["hello"]);
+    testResult("bar.com", [], {specificOnly: true});
     testResult("bar.com", ["hello"]);
     addException("foo.com#@#hello");
-    testResult("foo.com", [], true);
-    testResult("foo.com", [], false);
-    testResult("foo.com", []);
-    testResult("bar.com", [], true);
-    testResult("bar.com", ["hello"], false);
+    testResult("foo.com", [], {specificOnly: true});
+    testResult("foo.com", [], {expectedExceptions: ["foo.com#@#hello"]});
+    testResult("bar.com", [], {specificOnly: true});
     testResult("bar.com", ["hello"]);
     removeException("foo.com#@#hello");
-    testResult("foo.com", [], true);
+    testResult("foo.com", [], {specificOnly: true});
     // Note: We don't take care to track conditional selectors which became
     //       unconditional when a filter was removed. This was too expensive.
-    testResult("foo.com", ["hello"], false);
-    testResult("foo.com", ["hello"]);
-    testResult("bar.com", [], true);
-    testResult("bar.com", ["hello"], false);
+    testResult("foo.com", ["hello"]);
+    testResult("bar.com", [], {specificOnly: true});
     testResult("bar.com", ["hello"]);
     removeFilter("##hello");
     testResult("foo.com", []);
     testResult("bar.com", []);
 
     addFilter("##hello");
     addFilter("foo.com##hello");
     testResult("foo.com", ["hello"]);
     removeFilter("foo.com##hello");
     testResult("foo.com", ["hello"]);
     removeFilter("##hello");
     testResult("foo.com", []);
 
     addFilter("##hello");
     addFilter("foo.com##hello");
     testResult("foo.com", ["hello"]);
     removeFilter("##hello");
     testResult("foo.com", ["hello"]);
     removeFilter("foo.com##hello");
     testResult("foo.com", []);
   });
 
   it("Zero filter key", () =>
   {
     ElemHide.add(Filter.fromText("##test"));
     ElemHideExceptions.add(Filter.fromText("foo.com#@#test"));
-    testResult("foo.com", []);
+    testResult("foo.com", [], {expectedExceptions: ["foo.com#@#test"]});
     testResult("bar.com", ["test"]);
   });
 
   it("Filters by Domain", () =>
   {
     assert.equal(filtersByDomain.size, 0);
 
     ElemHide.add(Filter.fromText("##test"));
     assert.equal(filtersByDomain.size, 0);
 
@@ skipping 55 matching lines @@
     // terminated with a newline character, including the last rule. If this is
     // not the case, the function goes into an infinite loop. It should only be
     // used with the return value of the createStyleSheet function.
 
     assert.deepEqual([...rulesFromStyleSheet("")], []);
     assert.deepEqual([...rulesFromStyleSheet("#foo {}\n")], ["#foo {}"]);
     assert.deepEqual([...rulesFromStyleSheet("#foo {}\n#bar {}\n")],
                    ["#foo {}", "#bar {}"]);
   });
 });