Issue 6820 - Move tests to mocha

test/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 const assert = require("assert");
 
 let {
-  createSandbox, setupTimerAndXMLHttp, setupRandomResult, Cr
+  createSandbox, setupTimerAndFetch, setupRandomResult
 } = require("./_common");
 
 let Prefs = null;
 let Utils = null;
 let Notification = null;
+
+// Only starting NodeJS 10 that URL is in the global space.
+const {URL} = require("url");
 
 describe("Notifications", () =>
 {
   let runner = {};
 
   beforeEach(() =>
   {
     runner = {};
     // Inject our Array and JSON to make sure that instanceof checks on arrays
     // within the sandbox succeed even with data passed in from outside.
     let globals = Object.assign({Array, JSON},
-      setupTimerAndXMLHttp.call(runner), setupRandomResult.call(runner));
+      setupTimerAndFetch.call(runner), setupRandomResult.call(runner));
 
     let sandboxedRequire = createSandbox({globals});
     (
       {Prefs} = sandboxedRequire("./stub-modules/prefs"),
       {Utils} = sandboxedRequire("./stub-modules/utils"),
       {Notification} = sandboxedRequire("../lib/notification")
     );
   });
 
-  function showNotifications(url)
+  function showNotifications(location)
   {
     let shownNotifications = [];
     function showListener(notification)
     {
       shownNotifications.push(notification);
       Notification.markAsShown(notification.id);
     }
     Notification.addShowListener(showListener);
-    Notification.showNext(url);
+    Notification.showNext(location && new URL(location));
     Notification.removeShowListener(showListener);
     return shownNotifications;
   }
 
   function* pairs(array)
   {
     for (let element1 of array)
     {
       for (let element2 of array)
       {
         if (element1 != element2)
           yield [element1, element2];
       }
     }
   }
 
   function registerHandler(notifications, checkCallback)
   {
     runner.registerHandler("/notification.json", metadata =>
     {
       if (checkCallback)
         checkCallback(metadata);
 
       let notification = {
         version: 55,
         notifications
       };
 
-      return [Cr.NS_OK, 200, JSON.stringify(notification)];
+      return [200, JSON.stringify(notification)];
     });
   }
 
   it("No Data", () =>
   {
     assert.deepEqual(showNotifications(), [], "No notifications should be returned if there is no data");
   });
 
   it("Single Notificaion", () =>
   {
@@ skipping 334 matching lines @@
 
     registerHandler.call(this, [relentless]);
     return runner.runScheduledTasks(1).then(() =>
     {
       assert.deepEqual(showNotifications(), [relentless], "Relentless notifications are shown initially");
     }).then(() =>
     {
       assert.deepEqual(showNotifications(), [], "Relentless notifications are not shown before the interval");
     }).then(() =>
     {
-      // Date always returns a fixed time (see setupTimerAndXMLHttp) so we
+      // Date always returns a fixed time (see setupTimerAndFetch) so we
       // manipulate the shown data manually.
       Prefs.notificationdata.shown[relentless.id] -= relentless.interval;
       assert.deepEqual(showNotifications(), [relentless], "Relentless notifications are shown after the interval");
     });
   });
 
   it("Relentless notification", () =>
   {
     let relentless = {
       id: 3,
       type: "relentless",
       interval: 100,
       urlFilters: ["foo.com$document", "bar.foo$document"]
     };
 
     registerHandler.call(this, [relentless]);
     return runner.runScheduledTasks(1).then(() =>
     {
       assert.deepEqual(showNotifications(), [], "Relentless notification is not shown without URL");
       assert.deepEqual(showNotifications("http://bar.com"), [], "Relentless notification is not shown for a non-matching URL");
       assert.deepEqual(showNotifications("http://foo.com"), [relentless], "Relentless notification is shown for a matching URL");
     }).then(() =>
     {
       assert.deepEqual(showNotifications("http://foo.com"), [], "Relentless notifications are not shown before the interval");
     }).then(() =>
     {
-      // Date always returns a fixed time (see setupTimerAndXMLHttp) so we
+      // Date always returns a fixed time (see setupTimerAndFetch) so we
       // manipulate the shown data manually.
       Prefs.notificationdata.shown[relentless.id] -= relentless.interval;
       assert.deepEqual(showNotifications(), [], "Relentless notifications are not shown after the interval without URL");
       assert.deepEqual(showNotifications("http://bar.com"), [], "Relentless notifications are not shown after the interval for a non-matching URL");
       assert.deepEqual(showNotifications("http://bar.foo.com"), [relentless], "Relentless notifications are shown after the interval for a matching URL");
     });
   });
 
   it("Global opt-out", () =>
   {
@@ skipping 86 matching lines @@
   });
 
   it("Missing translation", () =>
   {
     let notification = {message: {"en-US": "en-US"}};
     Utils.appLocale = "fr";
     let texts = Notification.getLocalizedTexts(notification);
     assert.equal(texts.message, "en-US");
   });
 });