Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: tests/test_rpy.py

Issue 30031558: Issue 7391 - Let rpy recursively parse filter options to dicts (Closed) Base URL: https://hg.adblockplus.org/python-abp
Left Patch Set: Created March 21, 2019, 11:12 p.m.
Right Patch Set: Remove all OrderedDicts Created April 12, 2019, 6:30 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « abp/filters/rpy.py ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This file is part of Adblock Plus <https://adblockplus.org/>, 1 # This file is part of Adblock Plus <https://adblockplus.org/>,
2 # Copyright (C) 2006-present eyeo GmbH 2 # Copyright (C) 2006-present eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 'filter_multiple': { 85 'filter_multiple': {
86 'in': b'foo.com,bar.com##div#ad1', 86 'in': b'foo.com,bar.com##div#ad1',
87 'out': { 87 'out': {
88 b'type': b'Filter', 88 b'type': b'Filter',
89 b'text': b'foo.com,bar.com##div#ad1', 89 b'text': b'foo.com,bar.com##div#ad1',
90 b'selector': {b'type': b'css', b'value': b'div#ad1'}, 90 b'selector': {b'type': b'css', b'value': b'div#ad1'},
91 b'action': b'hide', 91 b'action': b'hide',
92 b'options': {b'domain': {b'foo.com': True, b'bar.com': True}}, 92 b'options': {b'domain': {b'foo.com': True, b'bar.com': True}},
93 }, 93 },
94 }, 94 },
95 'filter_with_sitekey_list': {
96 'in': b'@@bla$ping,domain=foo.com|~bar.foo.com,sitekey=foo|bar',
97 'out': {
98 b'text':
99 b'@@bla$ping,domain=foo.com|~bar.foo.com,sitekey=foo|bar',
100 b'selector': {b'value': b'bla', b'type': b'url-pattern'},
101 b'action': b'allow',
102 b'options': {
103 b'ping': True,
104 b'domain': {b'foo.com': True,
105 b'bar.foo.com': False},
106 b'sitekey': [b'foo', b'bar']},
107 b'type': b'Filter',
108 },
109 },
95 } 110 }
96 111
97 112
98 def check_data_utf8(data): 113 def check_data_utf8(data):
99 """Check if all the strings in a dict are encoded as unicode. 114 """Check if all the strings in a dict are encoded as unicode.
100 115
101 Parameters 116 Parameters
102 ---------- 117 ----------
103 data: dict 118 data: dict
104 The dictionary to be checked 119 The dictionary to be checked
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 """Test that the API returns the correct result in the appropriate format. 190 """Test that the API returns the correct result in the appropriate format.
176 191
177 By default, lines2dicts() does not correctly parse headers and metadata. 192 By default, lines2dicts() does not correctly parse headers and metadata.
178 """ 193 """
179 tests = [t for t in _TEST_EXAMPLES.values() 194 tests = [t for t in _TEST_EXAMPLES.values()
180 if t['out'][b'type'] not in {b'Header', b'Metadata'}] 195 if t['out'][b'type'] not in {b'Header', b'Metadata'}]
181 ins = [ex['in'] for ex in tests] 196 ins = [ex['in'] for ex in tests]
182 outs = [ex['out'] for ex in tests] 197 outs = [ex['out'] for ex in tests]
183 198
184 assert lines2dicts(ins) == outs 199 assert lines2dicts(ins) == outs
LEFTRIGHT

Powered by Google App Engine
This is Rietveld