Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 30032558: Noissue - Fix tests on NodeJS < 10 (Closed)

Created:
March 27, 2019, 6:58 p.m. by hub
Modified:
March 28, 2019, 12:23 p.m.
Reviewers:
Manish Jethani
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Fix tests on NodeJS < 10

Patch Set 1 #

Patch Set 2 : Remove URL from eslint globals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/.eslintrc.json View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/notification.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
hub
March 27, 2019, 6:58 p.m. (2019-03-27 18:58:50 UTC) #1
Manish Jethani
We should also remove the entry from `test/.eslintrc.json` since it is no longer necessary.
March 28, 2019, 7:51 a.m. (2019-03-28 07:51:56 UTC) #2
hub
Done Patch updated.
March 28, 2019, 11:49 a.m. (2019-03-28 11:49:07 UTC) #3
Manish Jethani
March 28, 2019, 12:05 p.m. (2019-03-28 12:05:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld