Noissue - Fix tests on NodeJS < 10

test/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 let {
-  createSandbox, setupTimerAndXMLHttp, setupRandomResult, unexpectedError
+  createSandbox, setupTimerAndFetch, setupRandomResult, unexpectedError
 } = require("./_common");
 
 let Prefs = null;
 let Utils = null;
 let Notification = null;
 
 // Only starting NodeJS 10 that URL is in the global space.
 const {URL} = require("url");
 
 exports.setUp = function(callback)
 {
   // Inject our Array and JSON to make sure that instanceof checks on arrays
   // within the sandbox succeed even with data passed in from outside.
   let globals = Object.assign({Array, JSON},
-    setupTimerAndXMLHttp.call(this), setupRandomResult.call(this));
+    setupTimerAndFetch.call(this), setupRandomResult.call(this));
 
   let sandboxedRequire = createSandbox({globals});
   (
     {Prefs} = sandboxedRequire("./stub-modules/prefs"),
     {Utils} = sandboxedRequire("./stub-modules/utils"),
     {Notification} = sandboxedRequire("../lib/notification")
   );
 
   callback();
 };
@@ skipping 381 matching lines @@
 
   registerHandler.call(this, [relentless]);
   this.runScheduledTasks(1).then(() =>
   {
     test.deepEqual(showNotifications(), [relentless], "Relentless notifications are shown initially");
   }).then(() =>
   {
     test.deepEqual(showNotifications(), [], "Relentless notifications are not shown before the interval");
   }).then(() =>
   {
-    // Date always returns a fixed time (see setupTimerAndXMLHttp) so we
+    // Date always returns a fixed time (see setupTimerAndFetch) so we
     // manipulate the shown data manually.
     Prefs.notificationdata.shown[relentless.id] -= relentless.interval;
     test.deepEqual(showNotifications(), [relentless], "Relentless notifications are shown after the interval");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
 
 exports.testRelentlessNotification = function(test)
 {
   let relentless = {
     id: 3,
     type: "relentless",
     interval: 100,
     urlFilters: ["foo.com$document", "bar.foo$document"]
   };
 
   registerHandler.call(this, [relentless]);
   this.runScheduledTasks(1).then(() =>
   {
     test.deepEqual(showNotifications(), [], "Relentless notification is not shown without URL");
     test.deepEqual(showNotifications("http://bar.com"), [], "Relentless notification is not shown for a non-matching URL");
     test.deepEqual(showNotifications("http://foo.com"), [relentless], "Relentless notification is shown for a matching URL");
   }).then(() =>
   {
     test.deepEqual(showNotifications("http://foo.com"), [], "Relentless notifications are not shown before the interval");
   }).then(() =>
   {
-    // Date always returns a fixed time (see setupTimerAndXMLHttp) so we
+    // Date always returns a fixed time (see setupTimerAndFetch) so we
     // manipulate the shown data manually.
     Prefs.notificationdata.shown[relentless.id] -= relentless.interval;
     test.deepEqual(showNotifications(), [], "Relentless notifications are not shown after the interval without URL");
     test.deepEqual(showNotifications("http://bar.com"), [], "Relentless notifications are not shown after the interval for a non-matching URL");
     test.deepEqual(showNotifications("http://bar.foo.com"), [relentless], "Relentless notifications are shown after the interval for a matching URL");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
 
 exports.testGlobalOptOut = function(test)
 {
@@ skipping 89 matching lines @@
 };
 
 exports.testMissingTranslation = function(test)
 {
   let notification = {message: {"en-US": "en-US"}};
   Utils.appLocale = "fr";
   let texts = Notification.getLocalizedTexts(notification);
   test.equal(texts.message, "en-US");
   test.done();
 };