Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 30034555: Issue 7386 - Default search engine is not preserved during upgrade (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 3 weeks ago by diegocarloslima
Modified:
7 months, 1 week ago
Reviewers:
jens, anton
Visibility:
Public.

Description

Issue 7386 - Default search engine is not preserved during upgrade

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -156 lines) Patch
M abb-build/transform_locales.py View 4 chunks +169 lines, -156 lines 5 comments Download

Messages

Total messages: 5
diegocarloslima
The main reason for this bug was because the id of duckduckgo changed. I also ...
7 months, 3 weeks ago (2019-03-29 12:51:01 UTC) #1
jens
On 2019/03/29 12:51:01, diegocarloslima wrote: > The main reason for this bug was because the ...
7 months, 2 weeks ago (2019-04-05 11:27:57 UTC) #2
diegocarloslima
On 2019/04/05 11:27:57, jens wrote: > On 2019/03/29 12:51:01, diegocarloslima wrote: > > The main ...
7 months, 2 weeks ago (2019-04-05 11:52:35 UTC) #3
jens
On 2019/04/05 11:52:35, diegocarloslima wrote: > On 2019/04/05 11:27:57, jens wrote: > > On 2019/03/29 ...
7 months, 2 weeks ago (2019-04-05 12:36:08 UTC) #4
anton
7 months, 2 weeks ago (2019-04-05 12:42:24 UTC) #5
LGTM though (not too deep)

https://codereview.adblockplus.org/30034555/diff/30034556/abb-build/transform...
File abb-build/transform_locales.py (right):

https://codereview.adblockplus.org/30034555/diff/30034556/abb-build/transform...
abb-build/transform_locales.py:187: 
unrequired line?

https://codereview.adblockplus.org/30034555/diff/30034556/abb-build/transform...
abb-build/transform_locales.py:267: 
unrequired line?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5