Issue 7428, 7400 - Add test case for nested :-abp-properties()

test/browser/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 511 matching lines @@
     middile: true,
     inside: true,
     sibling: true,
     sibling2: true,
     toHide: true
   };
   runTestPseudoClassHasSelectorWithHasAndWithSuffixSibling(
     test, "div:-abp-has(> span:-abp-contains(Advertisment))", expectations);
 };
 
+// See issue https://issues.adblockplus.org/ticket/7359
+// and issue https://issues.adblockplus.org/ticket/7428
+async function runTestQualifier(test, selector)
+{
+  testDocument.body.innerHTML = `
+    <style>
+    span::before {
+      content: "any";
+    }
+    </style>
+    <div id="toHide">
+      <a>
+        <p>
+          <span></span>
+        </p>
+      </a>
+    </div>`;
+
+  if (await applyElemHideEmulation(test, [selector]))
+    expectHidden(test, testDocument.getElementById("toHide"));
+
+  test.done();
+}
+
+exports.testPropertySelectorCombinatorQualifier = function(test)
+{
+  runTestQualifier(
+    test,
+    "div:-abp-has(> a p > :-abp-properties(content: \"any\"))"
+  );
+};
+
+exports.testPropertySelectorCombinatorQualifierNested = function(test)
+{
+  runTestQualifier(
+    test,
+    "div:-abp-has(> a p:-abp-has(> span:-abp-properties(content: \"any\")))"

[Manish Jethani, 2019/04/03 18:37:40]

Thanks for rebasing, it is looking good now, but some more comments ...

This test here is not about a combinator qualifier, because the selector is
`> span`, which is not the case we fixed for combinators. Instead we can make it
exactly like the previous test: `div:-abp-has(> a p:-abp-has(>
:-abp-properties(content: \"any\")))`, i.e. remove "span".

Then ... we can add two more tests (if you like):

  div:-abp-has(span:-abp-properties(content: \"any\"))
  div:-abp-has(p:-abp-has(span:-abp-properties(content: \"any\")))

Here we would be testing specifically for 7400, which is about the case where
the original selector and the qualifier both end in the same type. We could call
these tests `testPropertySelectorIdenticalTypeQualifier` and
`testPropertySelectorIdenticalTypeQualifierNested` respectively.

If we include these last two suggestions (it is up to you), then we should
reference 7400 in the commit message.

[hub, 2019/04/03 18:53:20]

Done.

+  );
+};
+
 async function runTestPseudoClassContains(test, selector, expectations)
 {
   testDocument.body.innerHTML = `<div id="parent">
       <div id="middle">
         <div id="middle1"><div id="inside" class="inside"></div></div>
       </div>
       <div id="sibling">
         <div id="tohide">to hide \ud83d\ude42!</div>
       </div>
       <div id="sibling2">
@@ skipping 523 matching lines @@
     {
       if (element.id == "n2" || element.id == "n2_3")
         expectProcessed(test, element, element.id);
       else
         expectNotProcessed(test, element, element.id);
     }
   }
 
   test.done();
 };