Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: tests/test_stats/data/filterhits.csv
Issue
30037555
:
NoIssue - Added filterhit statistics loading capability
Patch Set: Addressed Initial Comments
Created April 3, 2019, 5:15 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Removed .DS_Store files
Patch Set 3: Addressed Initial Comments
Patch Set 4: Addressed final comments (for real now)
Right:
Patch Set 1: None
Patch Set 2: Removed .DS_Store files
Patch Set 3: Addressed Initial Comments
Patch Set 4: Addressed final comments (for real now)
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
abp/stats/__init__.py
abp/stats/filterhits.py
setup.py
tests/test_stats/data/filterhits.csv
tests/test_stats/data/filterhits_missing_columns.csv
tests/test_stats/test_filtehits_loader.py
View unified diff
|
Download patch
« no previous file with comments
|
« setup.py
('k') |
tests/test_stats/data/filterhits_missing_columns.csv »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
filter,source,onehour_sessions,hits,domains,rootdomains
2
@@some_website.com,www.exceptionlist.com,10000,2345678,100,35
3
||subdomain.some_website.com,www.blocklist.com,100,1234,24,33
OLD
NEW
« no previous file with comments
|
« setup.py
('k') |
tests/test_stats/data/filterhits_missing_columns.csv »
('j') |
no next file with comments »
Edit Message
Issue 30037555: NoIssue - Added filterhit statistics loading capability
Created April 3, 2019, 4:07 p.m. by Tudor Avram
Modified April 3, 2019, 5:31 p.m.
Reviewers: Vasily Kuznetsov
Base URL:
Comments: 3
This is Rietveld