Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 30047570: Issue 7467 - Migrate rpy to Python 3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by rhowell
Modified:
2 months, 3 weeks ago
Reviewers:
Vasily Kuznetsov, sporz
Base URL:
https://hg.adblockplus.org/python-abp
Visibility:
Public.

Description

Issue 7467 - Migrate rpy to Python 3 Repository: https://hg.adblockplus.org/python-abp Base revision: 23b461979bd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -112 lines) Patch
M abp/filters/rpy.py View 3 chunks +1 line, -27 lines 0 comments Download
M tests/test_rpy.py View 4 chunks +46 lines, -85 lines 0 comments Download

Messages

Total messages: 4
rhowell
4 months ago (2019-04-18 00:15:24 UTC) #1
Vasily Kuznetsov
Hi Rosie! LGTM, however please don't push it yet. Let's add Stephan to this review ...
4 months ago (2019-04-18 11:50:26 UTC) #2
sporz
Works, LGTM! Also: Speedup increase between line2dict and lines2dict is now 10 fold.
2 months, 3 weeks ago (2019-05-31 09:40:07 UTC) #3
Vasily Kuznetsov
2 months, 3 weeks ago (2019-05-31 10:04:07 UTC) #4
On 2019/05/31 09:40:07, sporz wrote:
> Works, LGTM!
> 
> Also: Speedup increase between line2dict and lines2dict is now 10 fold.

Amazing! Great to hear that.

Rosie, you can just push change this directly to the GitLab repo: pushing to
hg.adblockplus.org/python-abp is now disabled.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5