Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(422)

Issue 30047570: Issue 7467 - Migrate rpy to Python 3

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by rhowell
Modified:
1 month ago
Reviewers:
sporz, Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/python-abp
Visibility:
Public.

Description

Issue 7467 - Migrate rpy to Python 3 Repository: https://hg.adblockplus.org/python-abp Base revision: 23b461979bd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -112 lines) Patch
M abp/filters/rpy.py View 3 chunks +1 line, -27 lines 0 comments Download
M tests/test_rpy.py View 4 chunks +46 lines, -85 lines 0 comments Download

Messages

Total messages: 2
rhowell
1 month, 1 week ago (2019-04-18 00:15:24 UTC) #1
Vasily Kuznetsov
1 month, 1 week ago (2019-04-18 11:50:26 UTC) #2
Hi Rosie!

LGTM, however please don't push it yet. Let's add Stephan to this review and
check that this version actually works for him. Then when the Data team is ready
to switch to Python 3 with Reticulate, we can push.

Cheers,
Vasily
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5