Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(111)

Issue 30048555: Issue 7334 - Remove handling of "Fixes XXXX - ..." commit messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months ago by Vasily Kuznetsov
Modified:
9 months, 1 week ago
Reviewers:
mathias
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/sitescripts
Visibility:
Public.

Description

Issue 7334 - Remove handling of "Fixes XXXX - ..." commit messages Repository: https://hg.adblockplus.org/sitescripts Base revision: 518c14e605e3

Patch Set 1 #

Total comments: 17

Patch Set 2 : Address review comments on PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -435 lines) Patch
M .sitescripts.example View 1 chunk +0 lines, -4 lines 0 comments Download
M sitescripts/hg/README.md View 1 1 chunk +14 lines, -58 lines 0 comments Download
M sitescripts/hg/bin/update_issues.py View 1 1 chunk +52 lines, -166 lines 0 comments Download
M sitescripts/hg/test/test_update_issues.py View 1 1 chunk +59 lines, -207 lines 0 comments Download

Messages

Total messages: 8
Vasily Kuznetsov
Hey Matze! WebExt team started using "Fixes XXXX ..." commit messages to refer to GitLab ...
10 months ago (2019-04-18 16:04:22 UTC) #1
mathias
The approach makes sense and the patch-set looks promising to me. Do you want me ...
10 months ago (2019-04-20 19:19:23 UTC) #2
Vasily Kuznetsov
On 2019/04/20 19:19:23, mathias wrote: > The approach makes sense and the patch-set looks promising ...
10 months ago (2019-04-21 09:26:02 UTC) #3
mathias
I like this patch-set very much. Not sure if I am missing something, i.e. if ...
9 months, 1 week ago (2019-05-13 12:23:43 UTC) #4
Vasily Kuznetsov
> I like this patch-set very much. No wonder, it deletes code! :D https://codereview.adblockplus.org/30048555/diff/30048556/sitescripts/hg/bin/update_issues.py File ...
9 months, 1 week ago (2019-05-13 15:14:15 UTC) #5
mathias
https://codereview.adblockplus.org/30048555/diff/30048556/sitescripts/hg/README.md File sitescripts/hg/README.md (right): https://codereview.adblockplus.org/30048555/diff/30048556/sitescripts/hg/README.md#newcode44 sitescripts/hg/README.md:44: The hook requires `Jinja2` to be importable by the ...
9 months, 1 week ago (2019-05-14 09:32:02 UTC) #6
Vasily Kuznetsov
Hi Matze! Thanks for further comments. I've addressed everything. Let me know if anything else ...
9 months, 1 week ago (2019-05-14 10:29:00 UTC) #7
mathias
9 months, 1 week ago (2019-05-14 10:31:14 UTC) #8
LGTM. Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5