Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 30061555: Noissue - Added info.locale (Closed)

Created:
Oct. 4, 2019, 11:54 p.m. by Sebastian Noack
Modified:
Oct. 8, 2019, 9:08 p.m.
Reviewers:
tlucas
Visibility:
Public.

Description

Noissue - Added info.locale

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -34 lines) Patch
M packagerChrome.py View 2 chunks +2 lines, -6 lines 0 comments Download
M templates/chromeInfo.js.tmpl View 2 chunks +3 lines, -9 lines 0 comments Download
M templates/edgeInfo.js.tmpl View 1 chunk +4 lines, -10 lines 0 comments Download
M templates/geckoInfo.js.tmpl View 1 chunk +3 lines, -9 lines 0 comments Download
A templates/info.js.tmpl View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Hey did you miss Rietveld yet? ;) Or in case you are wondering WTF, while ...
Oct. 5, 2019, 12:02 a.m. (2019-10-05 00:02:59 UTC) #1
Sebastian Noack
One more thing, tox currently fails, but I get the same failure without the changes ...
Oct. 5, 2019, 12:05 a.m. (2019-10-05 00:05:27 UTC) #2
tlucas
On 2019/10/05 00:05:27, Sebastian Noack wrote: > One more thing, tox currently fails, but I ...
Oct. 5, 2019, 4:56 p.m. (2019-10-05 16:56:25 UTC) #3
Sebastian Noack
Oct. 8, 2019, 9:08 p.m. (2019-10-08 21:08:15 UTC) #4
Message was sent while issue was closed.
For reference, I backed out this change again, as we decided to get rid of
Utils.appLocale/info.locale altogether.

Powered by Google App Engine
This is Rietveld