packagerChrome.py - Issue 30061555: Noissue - Added info.locale

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: packagerChrome.py

Issue 30061555: Noissue - Added info.locale (Closed)

Patch Set: Created Oct. 4, 2019, 11:54 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: packagerChrome.py

===================================================================

--- a/packagerChrome.py

+++ b/packagerChrome.py

@@ -151,11 +151,6 @@

def create_bundles(params, files, bundle_tests):

base_extension_path = params['baseDir']

- info_templates = {

- 'chrome': 'chromeInfo.js.tmpl',

- 'edge': 'edgeInfo.js.tmpl',

- 'gecko': 'geckoInfo.js.tmpl',

- }

aliases = {

# To use our custom loader for the info module we must first set up an

# alias to a file that exists.

@@ -179,10 +174,11 @@

resolve_paths = [os.path.join(base_extension_path, dir, 'lib')

for dir in ['', 'adblockpluscore', 'adblockplusui']]

- info_template = getTemplate(info_templates[params['type']])

+ info_template = getTemplate('info.js.tmpl')

info_module = info_template.render(

basename=params['metadata'].get('general', 'basename'),

version=params['version'],

+ type=params['type'],

).encode('utf-8')

configuration = {

« no previous file with comments | « no previous file | templates/chromeInfo.js.tmpl » ('j') | no next file with comments »