Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1013)

Issue 30062555: Noissue - Add '.revision'-file to devbuilds

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by tlucas
Modified:
1 month ago
Reviewers:
Sebastian Noack
CC:
Sebastian Noack
Visibility:
Public.

Description

Noissue - Add '.revision'-file to devbuilds This references https://gitlab.com/eyeo/adblockplus/adblockpluschrome/issues/88 , the dependency update to this change will happen in https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/126

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M packagerChrome.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5
tlucas
Patch Set 1: Add `.revision`-file to devbuilds.
1 month, 1 week ago (2019-10-10 15:42:50 UTC) #1
tlucas
> Rietveld is down again. So I review this patch here: > 1. Right now, ...
1 month ago (2019-10-11 11:48:55 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/30062555/diff/30063555/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/30062555/diff/30063555/packagerChrome.py#newcode403 packagerChrome.py:403: add_revision_file(baseDir, files) Splitting this out into a function seems ...
1 month ago (2019-10-11 21:18:43 UTC) #3
tlucas
Patch Set 3 Fully adapated Sebastian's suggestion https://codereview.adblockplus.org/30062555/diff/30063555/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/30062555/diff/30063555/packagerChrome.py#newcode403 packagerChrome.py:403: add_revision_file(baseDir, files) ...
1 month ago (2019-10-14 12:14:54 UTC) #4
Sebastian Noack
1 month ago (2019-10-15 00:17:43 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5