Unified Diff: options.js
Issue 4515985834901504:
Issue 2664 - Remove ignoreHeaders argument from parseFilter(s) and move the logic to the UI (Closed)
Patch Set:
Created June 8, 2015, 4:46 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/filterValidation.js ('k')
|
qunit/tests/filterValidation.js » ('j')
|
qunit/tests/filterValidation.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.js |
| =================================================================== |
| --- a/options.js |
| +++ b/options.js |
| @@ -537,11 +537,19 @@ |
| function importRawFiltersText() |
| { |
| var text = document.getElementById("rawFiltersText").value; |
| - var result = parseFilters(text, true); |
| + var result = parseFilters(text); |
| - if (result.error) |
| + var errors = []; |
| + for (var i = 0; i < result.errors.length; i++) |
| { |
| - alert(result.error); |
| + var error = result.errors[i]; |
| + if (error.type != "unexpected-filter-list-header") |
| + errors.push(error); |
| + } |
|
Wladimir Palant
2015/06/08 18:15:47
Why not:
var errors = result.errors.filter(fun
Sebastian Noack
2015/06/08 18:36:46
Done.
|
| + |
| + if (errors.length > 0) |
| + { |
| + alert(errors.join("\n")); |
| return; |
| } |
« no previous file with comments
|
« lib/filterValidation.js ('k')
|
qunit/tests/filterValidation.js » ('j')
|
qunit/tests/filterValidation.js » ('J')
