Fix: issue with chrome v28 and below

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2013 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 168 matching lines @@
 
   var BackgroundMessageEventTarget = function()
   {
     MessageEventTarget.call(this);
   }
   BackgroundMessageEventTarget.prototype = {
     __proto__: MessageEventTarget.prototype,
     _wrapSender: function(sender)
     {
       var tab = new Tab(sender.tab);
+      
+      //url parameter is missing in sender object (Chrome v28 and below)
+      //It's a temporary fix ( http://codereview.adblockplus.org/4538458420805632/ )

[Felix Dahlke, 2014/02/27 20:45:25]

I'd get rid of this line, doesn't add much. The first one makes sense of course.

[saroyanm, 2014/02/28 12:47:15]

Done.

       if (sender.url == null);

[Thomas Greiner, 2014/02/10 11:05:34]

Add a comment above why this is necessary and investigate further which versions
are affected by this so that we know when it's safe to get rid of it again.

e.g. "Chrome 21-26 does not pass sender.url"

[Felix Dahlke, 2014/02/27 20:46:39]

Actually, why check for null here? Isn't the url parameter missing on Chrome
<28? In that case it should be:

if (!("url in sender))

[saroyanm, 2014/02/28 12:47:15]

Thanks for pointing.

         sender.url = tab.url;
       return {tab: tab, frame: new Frame({url: sender.url, tab: tab})};
     }
   };
 
 
   /* Tabs */
 
   var sendMessage = chrome.tabs.sendMessage || chrome.tabs.sendRequest;
 
@@ skipping 375 matching lines @@
       if (isContextMenuHidden)
         return;
 
       chrome.contextMenus.removeAll();
       isContextMenuHidden = true;
     }
   };
 
   ext.onMessage = new BackgroundMessageEventTarget();
 })();