Unified Diff: chrome/ext/background.js
Issue 4538458420805632:
Fix: issue with chrome v28 and below (Closed)
Patch Set: Descriptive comment
Created Feb. 13, 2014, 2:41 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: chrome/ext/background.js |
| =================================================================== |
| --- a/chrome/ext/background.js |
| +++ b/chrome/ext/background.js |
| @@ -186,6 +186,11 @@ |
| _wrapSender: function(sender) |
| { |
| var tab = new Tab(sender.tab); |
| + |
| + //url parameter is missing in sender object (Chrome v28 and below) |
| + //It's a temporary fix ( http://codereview.adblockplus.org/4538458420805632/ ) |
|
Felix Dahlke
2014/02/27 20:45:25
I'd get rid of this line, doesn't add much. The fi
saroyanm
2014/02/28 12:47:15
Done.
|
| + if (sender.url == null); |
|
Felix Dahlke
2014/02/27 20:46:39
Actually, why check for null here? Isn't the url p
saroyanm
2014/02/28 12:47:15
Thanks for pointing.
|
| + sender.url = tab.url; |
| return {tab: tab, frame: new Frame({url: sender.url, tab: tab})}; |
| } |
| }; |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
